Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support flags as options in .gulprc file #71

Closed
phated opened this issue Apr 5, 2016 · 7 comments
Closed

Support flags as options in .gulprc file #71

phated opened this issue Apr 5, 2016 · 7 comments

Comments

@phated
Copy link
Member

phated commented Apr 5, 2016

The flags should be able to be defaulted in the .gulprc file so people can rely on gulpfiles running in a certain way. e.g. running with a certain log level

@phated phated added this to the 1.3.0 milestone Apr 5, 2016
@phated
Copy link
Member Author

phated commented Aug 22, 2016

@sttk if you plan to implement more features in .gulp.*, start with this one before attempting #57 or #63

@sttk
Copy link
Contributor

sttk commented Aug 23, 2016

@phated Since the configs are merged with opts, the flags are already able to be configured with .gulp.* files.

But those values aren't checked at all. Are the checks needed and are there any flags forbidden to configure with .gulp.* files?

@phated
Copy link
Member Author

phated commented Aug 23, 2016

@sttk oh, I don't think that's the way I wanted it to work. flags should be a property that gets merged into the flag options. How should we handle this?

@phated
Copy link
Member Author

phated commented Apr 22, 2017

Basic support for this was completed by #92
@sttk does that PR add support for every flag or just the ones specified? If it only supports a subset, should we leave this open?

@phated phated modified the milestones: 1.3.0, 1.4.0 Apr 23, 2017
@sttk
Copy link
Contributor

sttk commented Apr 23, 2017

@phated I think #92 is for creating mechanism to support flags.
We may add other flags or configs later as needs or requests.
So this issue might be closed.

@sttk
Copy link
Contributor

sttk commented Apr 23, 2017

@phated Or are there any flags what you are already thinking that we should add?
I'll implement to support those flags if you list them.

@phated
Copy link
Member Author

phated commented Apr 26, 2017

I think I've opened issues for the 3 remaining flags that make sense as config options. See #108 #109 and #110

@phated phated closed this as completed Apr 26, 2017
@phated phated removed this from the 1.4.0 milestone Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants