-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to NOT run fs.chmod() on destination files #1502
Comments
3.9 won't be receiving this change; we could probably do it for gulp 4. |
It looks like the chmod problem was fixed in 9 months ago (#1012) but still not in a released version. It's been driving me crazy too. |
@kcivey from the issue you linked to:
|
For who's interested in an ugly hack, I did this, in gulpfile.js: I haven't tested gulp v4.0 but I do wonder if it won't still crash, since I also am having default 'setfacl' settings for directories. |
Lots of fixes have either landed in vinyl-fs or are about to land in vinyl-fs (avoiding the chmod if the process uid is not the same as the file owner). If you don't want to upgrade to gulp 4, you can pull in vinyl-fs as the standalone module to have the fixes. node's module resolution might even pick it up for your gulp install if they are side-by-side. |
Well, I just tried using 4.0, but I get several unmet dependencies warnings. |
No, it isn't complete yet. |
Expanding upon that ^ - there are many people using it already so your system is messed up, not gulp 4. |
I started again from an empty package.json and added one by one the required dependencies. Still got some warnings about dependencies, but I ignored them. After doing the required changes in my gulpfile.js, guess what? I ended now with The file is there, user can write/append into it. So, I got the same bad behaviour I was complaining, if using setfacl. Then, I commented the call in ./node_modules/gulp/node_modules/vinyl-fs/lib/dest/writeContents/writeBuffer.js Vinyl-fs version: 2.3.1 |
As stated in my original post the change/fix for not attempting chmod if the process.uid doesn't match the file uid is still in progress and hasn't landed yet. I am going to lock this thread because it is causing additional noise to something that already is being worked on over in the vinyl-fs repo. |
I'm in the situation of having all the permission setup with 'setfacl' (for lxc containers) and I can NOT work at ALL with this setup because gulp's code always tries to run chmod, which fails miserably.
Can you please add an option where there is no chmod() call involved?
Gulp version 3.9.0
The text was updated successfully, but these errors were encountered: