Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add "What's new in 4.0" section (closes #2089) #2267

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Conversation

phated
Copy link
Member

@phated phated commented Dec 6, 2018

How's this look? Am I blatantly missing anything?

@contra @stevelacy @terinjokes @erikkemperman

Copy link
Member

@yocontra yocontra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - if theres an upgrade guide this would be a good place to link to it.

Copy link
Contributor

@terinjokes terinjokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only suggestion is that we link these bullets to the explanations in the docs.

@phated
Copy link
Member Author

phated commented Dec 6, 2018

@terinjokes I think being dropped into the APIs docs is pretty rough without reviewing the Getting Started guide first. I'm also planning to revamp the rest of the README to point to both the Getting Started guide and API docs.

@terinjokes
Copy link
Contributor

@phated I read @contra's message after I reviewed. If there's a Getting Started or migration guide, linking to that at the end of the list is probably fine.

@phated phated merged commit 75ea634 into master Dec 6, 2018
@phated phated deleted the whats-new branch December 6, 2018 22:59
@erikkemperman
Copy link
Member

Sorry, late response.. Still, nicely done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants