Fix: Bail gracefully on unknown extensions when nothrow is specified

gulpjs · Jan 4, 2019 · 529d9c0 · 529d9c0
1 parent 77cbc95
commit 529d9c0
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -15,7 +15,11 @@ exports.prepare = function (extensions, filepath, cwd, nothrow) {
   }
   var config = normalize(extensions[ext]);
   if (!config) {
-    throw new Error('No module loader found for "'+ext+'".');
+    if (nothrow) {
+      return;
+    } else {
+      throw new Error('No module loader found for "'+ext+'".');
+    }
   }
   if (!cwd) {
     cwd = path.dirname(path.resolve(filepath));

diff --git a/test/fixtures/.testrc b/test/fixtures/.testrc
@@ -0,0 +1,9 @@
+module.exports = {
+  data: {
+    trueKey: true,
+    falseKey: false,
+    subKey: {
+      subProp: 1
+    }
+  }
+};
diff --git a/test/index.js b/test/index.js
@@ -39,6 +39,10 @@ describe('rechoir', function () {
       }).to.throw(/No module loader found for/);
     });
 
+    it('should return undefined if an unknown extension is specified when nothrow is enabled', function () {
+      expect(rechoir.prepare(extensions, './test/fixtures/.testrc', null, true)).to.be.undefined;
+    });
+
     it('should throw if a module loader cannot be found or loaded', function () {
       expect(function () {
         require(testFilePath);