Fix series arguments having 0 lenght #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexHenkel
force-pushed
the
master
branch
2 times, most recently
from
641fe31 to
9464919
Compare
phated
requested changes
Feb 26, 2017
lib/helpers/normalizeArgs.js
Outdated
| @@ -16,7 +16,10 @@ function normalizeArgs(registry, args) { | |||
| return fn; | |||
| } | |||
|
|
|||
| return map(flatten(args), getFunction); | |||
| var flattenArgs = flatten(args); | |||
| assert(flattenArgs.length, 'Arguments must be a non-empty array or string'); | |||
There was a problem hiding this comment.
I think this message should be more user friendly. How does "One or more tasks must be combined using series or parallel" sound?
test/series.js
Outdated
| @@ -34,6 +34,42 @@ describe('series', function() { | |||
| done(); | |||
| }); | |||
|
|
|||
| it('should throw on empty object on registered tasks array', function(done) { | |||
| function fail() { | |||
| taker.series(['test1', 'test2', 'test3', {}]); | |||
There was a problem hiding this comment.
You can add another test for taker.series('test1', 'test2', 'test3', {}); (that's without the array).
test/series.js
Outdated
| done(); | ||
| }); | ||
|
|
||
| it('should throw on non registered tasks', function(done) { |
There was a problem hiding this comment.
"should throw when no tasks specified"
test/series.js
Outdated
| done(); | ||
| }); | ||
|
|
||
| it('should throw on empty object of registered task', function(done) { |
There was a problem hiding this comment.
"should throw on non-valid task"
|
@AlexHenkel this needs to mirror the |
phated
approved these changes
Feb 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
TODO