Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom write stream fix #203

Merged
merged 3 commits into from
Aug 15, 2016
Merged

Custom write stream fix #203

merged 3 commits into from
Aug 15, 2016

Conversation

doowb
Copy link
Member

@doowb doowb commented Aug 12, 2016

This is a fix and tests for #202.

I added a large file to the fixtures that demonstrates the issue.
I added tests to the file operations test file and the dest test file. These needed to use fs.createReadStream directly since from was writing the entire string to the stream at once.

@phated
Copy link
Member

phated commented Aug 13, 2016

Awesome, you can actually use from with a function to generate a really big file instead of including fixtures.

@doowb
remove large test file
28bbc2e 
added `string` stream method to test-streams for streaming a string
updated file-operations and dest tests to use the string stream for a large stream
reverted src tests back to the correct fixture count
@doowb
Copy link
Member Author

doowb commented Aug 13, 2016

@phated I updated the tests to use from to create the read stream.

@phated
Copy link
Member

phated commented Aug 15, 2016

Thanks for all the work on this and finding this bug! I'm going to merge and then tweak a few things.

@phated phated merged commit 7b2a84c into gulpjs:master Aug 15, 2016
phated pushed a commit that referenced this pull request Aug 15, 2016
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
750d55e
phated pushed a commit that referenced this pull request Jan 18, 2017
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
0212cd9
phated pushed a commit that referenced this pull request Nov 27, 2017
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
77e1057
phated pushed a commit that referenced this pull request Nov 27, 2017
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
ac31353
phated pushed a commit that referenced this pull request Nov 27, 2017
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
65bbb37
phated pushed a commit that referenced this pull request Nov 27, 2017
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
0b3c888
phated pushed a commit that referenced this pull request Nov 27, 2017
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
1783456
phated pushed a commit that referenced this pull request Nov 27, 2017
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
dd423f0
phated pushed a commit that referenced this pull request Nov 27, 2017
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
627b476
phated pushed a commit that referenced this pull request Nov 28, 2017
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
c736eea
phated pushed a commit that referenced this pull request Nov 28, 2017
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
40ed10c
phated pushed a commit that referenced this pull request Nov 28, 2017
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
f37b5f3
phated pushed a commit that referenced this pull request Nov 28, 2017
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
176ab76
phated pushed a commit that referenced this pull request Nov 28, 2017
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
375071e
phated pushed a commit that referenced this pull request Nov 28, 2017
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
2432b80
phated pushed a commit that referenced this pull request Nov 28, 2017
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
39c8b12
phated pushed a commit that referenced this pull request Nov 28, 2017
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
d1ad057
phated pushed a commit that referenced this pull request Nov 28, 2017
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
7462d58
phated pushed a commit that referenced this pull request Nov 28, 2017
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
549a5b4
phated pushed a commit that referenced this pull request Nov 28, 2017
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
8e79ae0
phated pushed a commit that referenced this pull request Nov 28, 2017
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
2da939f
phated pushed a commit that referenced this pull request Nov 28, 2017
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
27612bb
phated pushed a commit that referenced this pull request Nov 28, 2017
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
43ecece
phated pushed a commit that referenced this pull request Nov 28, 2017
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
8ea1280
phated pushed a commit that referenced this pull request Nov 28, 2017
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
bfd9ca8
phated pushed a commit that referenced this pull request Nov 28, 2017
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
cfb285a
phated pushed a commit that referenced this pull request Nov 28, 2017
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
d59ccc7
phated pushed a commit that referenced this pull request Nov 28, 2017
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
9b27021
phated pushed a commit that referenced this pull request Nov 30, 2017
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
cce88e7
phated pushed a commit that referenced this pull request Nov 30, 2017
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
8ae1534
phated pushed a commit that referenced this pull request Nov 30, 2017
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
98fb1ee
phated pushed a commit that referenced this pull request Nov 30, 2017
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
e6b6708
phated pushed a commit that referenced this pull request Nov 30, 2017
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
81f343b
phated pushed a commit that referenced this pull request Dec 5, 2017
@doowb @phated
Fix: Avoid setting a position in custom write stream (fixes #202) (#203)
8eda2b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doowb @phated