Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 10 broke some of our mode tests #300

Closed
phated opened this issue May 13, 2018 · 2 comments
Closed

Node 10 broke some of our mode tests #300

phated opened this issue May 13, 2018 · 2 comments

Comments

@phated
Copy link
Member

phated commented May 13, 2018

Ref https://travis-ci.org/gulpjs/vinyl-fs/jobs/378478047

I'm rolling back the build matrix for now.

@phated
Copy link
Member Author

phated commented Aug 18, 2018

I believe node's fixed this now

@phated
Copy link
Member Author

phated commented Nov 19, 2018

They fixed the mode stuff but they broke our closeFd tests. I've put in a patch that fixed that at 6aef383

@phated phated closed this as completed Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant