Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "loading" UI before emitting "ready" event #66

Open
edrpls opened this issue Dec 24, 2019 · 0 comments
Open

Add "loading" UI before emitting "ready" event #66

edrpls opened this issue Dec 24, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
2.0.0

Comments

@edrpls
Copy link

edrpls commented Dec 24, 2019 •
edited
Loading

Fixing #60 made the VAST load times more noticeable, it would be a good idea to include a UI when the video is loading, for both VAST and media sources. See Loading Dots.

This style could show by default and be removed on the function that emits the ready event.
@edrpls edrpls mentioned this issue Dec 24, 2019
Merged
@edrpls edrpls added good first issue Good for newcomers enhancement New feature or request labels Dec 24, 2019
@edrpls edrpls added this to the 2.0.0 milestone Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@edrpls