Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using any selector for the container property #74

Open
edrpls opened this issue Jan 18, 2020 · 1 comment
Open

Allow using any selector for the container property #74

edrpls opened this issue Jan 18, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
2.0.0

Comments

@edrpls
Copy link

edrpls commented Jan 18, 2020

Our current code allows two types for the container property, one is a DOM node that will be used as is, the other is a string that represents an id for the node to use.

We could improve this further by allowing the user to pass any selector allowed by querySelector.

If we detect that the value given is not a node and includes a special character, we will use querySelector, if there is no special char, we fallback to getElementById
@edrpls edrpls added enhancement New feature or request good first issue Good for newcomers labels Jan 18, 2020
@edrpls
Copy link
Author

edrpls commented Jan 18, 2020

Relates to #75

@edrpls edrpls added this to the 2.0.0 milestone Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@edrpls @mnicole