-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Angular 5 #69
Comments
Yes, I will prepare an upgraded version very soon. |
Hey there! Just published new next version of lib under $ npm install ng-dynamic-component@next All changes are currently in separate |
https://github.com/cankayacan/ng5-dynamic-component-test Getting this error:
|
Hi! There is another bug with official release of Angular 5.
Indeed in dynamic.module.d.ts:
No @NgModule annotation. Many thanks, |
Hey, you will not see any annotations in the I will publish stable version with v5 so you can try it |
Hello, I still get the error message ERROR Error: Unexpected value '[object Object]' imported by the module 'MonthlyBonusModule'. Please add a @NgModule annotation. Using ng5 - dynamic 2.0.1 & cli 1.5 |
Hmm... I will try on a sample app later. |
Yes, same for me. Good luck! |
I ran into the same issue today using CLI 1.5, NG 2.1 and ng-dynamic-component 2.0.1, like all the others. TooltipModule.decorators = [
{ type: NgModule, args: [{
imports: [CommonModule],
declarations: [TooltipDirective, TooltipContainerComponent],
exports: [TooltipDirective],
entryComponents: [TooltipContainerComponent]
},] },
]; This |
@lukaszbachman thanks for pointing to this, I will check why they are not appearing |
Just confirmed that NGC does not generate metadata anymore for the project... |
So I found this property called Really weird. |
@gund, this seems to be related angular/angular#20219 |
@elclanrs looks interesting but they are talking about code-gen of I just tried to use TSC with the same config and it did output all decorators - so it's purely NGCs issue now. Trying to build a reproduction app now... |
very simple, use TS@2.4.2 not 2.5.3 The problem is angular not notifying about it |
2.5.3 support can be tracked here angular/angular#20175 |
Hey @shlomiassaf thanks for the info. Just tried with TS v2.4 and it did work. Angular team already knows about the problem with decorators in TS v2.5 or it makes sense to create a repro app and link to the issue? |
I don't know... The issues are with tsickle mostly, not emitting the decorators... other then that you can AOT compile an app and it will work... Since it's one shot compile the data is kept |
You can try v2.0.2 - should be fixed |
I tried in Angular 5.0.0-rc.3 and I get an error the regarding the OpaqueToken export which is deprecated.
According to angular/angular#14427 you may just need replace these with
InjectionToken
instead.The text was updated successfully, but these errors were encountered: