Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue about the conv2d operation #20

Open
kelvinleen opened this issue Aug 9, 2019 · 2 comments
Open

issue about the conv2d operation #20

kelvinleen opened this issue Aug 9, 2019 · 2 comments

Comments

@kelvinleen
Copy link

as in #6 (comment), the implementation is not same as what the paper shows in equation 3.

i think line50 in model.py should be replaced as follows:
G = tf.expand_dims(G, axis=-1) # bsc1 filter: ngram1 filter_num:1
Att_v = tf.contrib.layers.conv2d(G, num_outputs=1, kernel_size=[opt.ngram,1], padding='SAME',activation_fn=tf.nn.relu) #b * s * c * 1
Att_v = tf.squeeze(Att_v,)

@SCAUapc
Copy link

SCAUapc commented Aug 23, 2019

I have the same problem as you. And i agree with you. But I wish can get the reply by the author

@AlexMoreo
Copy link

I think you are right. I had to do exactly the same modification (If only had I see your comment before... :D)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants