Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #333 #392

Merged
merged 8 commits into from
Apr 27, 2021
Merged

Fix #333 #392

merged 8 commits into from
Apr 27, 2021

Conversation

Gamebuster19901
Copy link
Contributor

@Gamebuster19901 Gamebuster19901 commented Apr 27, 2021

This pull request should fix #333. Sonarcloud should no longer run on repositories that are not gurkenlabs/litiengine.

Please change the target of this PR to a test branch before merging to ensure that sonarcloud sill works in your repository. If it works, merge that branch into master.

Do not merge this PR directly into master.

@Gamebuster19901 Gamebuster19901 marked this pull request as draft April 27, 2021 00:06
@Gamebuster19901 Gamebuster19901 marked this pull request as ready for review April 27, 2021 00:13
@Gamebuster19901 Gamebuster19901 marked this pull request as draft April 27, 2021 00:27
@Gamebuster19901 Gamebuster19901 marked this pull request as draft April 27, 2021 20:00
@nightm4re94
Copy link
Member

Sonar still works in the test branch.

@Gamebuster19901
Copy link
Contributor Author

Okay, I can't seem to resolve the merge conflict in Gamebuster19901#6. Are you able to merge test-branch-build into master?

@Gamebuster19901 Gamebuster19901 marked this pull request as ready for review April 27, 2021 20:24
@Gamebuster19901
Copy link
Contributor Author

Should be good to go once the builds succeed

@nightm4re94 nightm4re94 merged commit 93325fb into gurkenlabs:master Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Branch builds always fail in my repository
2 participants