Fix right to left issues #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guyonroche
requested changes
Jul 12, 2017
| @@ -43,6 +43,7 @@ utils.inherits(SheetViewXform, BaseXform, { | |||
| xmlStream.addAttribute(name, value); | |||
| } | |||
| }; | |||
| add('rightToLeft', '1', model.rtl === true); | |||
There was a problem hiding this comment.
there needs to be a corresponding line in the parseOpen function or it won't be able to read files properly
There was a problem hiding this comment.
Also - could you add this property to the unit test:
in spec/unit/xlsx/xform/sheet/sheet-view-xform.spec.js
| {k: 'l2r', v: 2}, | ||
| {k: Enums.ReadingOrder.RightToLeft, v: 1}, | ||
| {k: Enums.ReadingOrder.LeftToRight, v: 2} | ||
| {k: 'rtl', v: 2}, |
There was a problem hiding this comment.
Would you be able to add a unit test for these changes?
in spec/unit/xlsx/xform/style/alignment-xform.spec.js
|
@guyonroche I made the requested changes. I also renamed |
|
@alitaheri what a small world! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new property to sheet view. And fixes
readingOrderas it wasn't doing anything for 2 reasons:l2randr2linstead of the documentltrandrtlones.Closes #72
Closes #126