-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add type definition #490
add type definition #490
Conversation
I just want to help, and I am using this project in my work. |
Having typings for |
package.json
Outdated
@@ -98,4 +99,4 @@ | |||
"LICENSE", | |||
"README.md" | |||
] | |||
} | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ouch 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the formatter
Thanks @taoqf for doing this! |
How should I use this typings for my Typescript application? |
Just install this lib will be OK, after new version if published. |
Any idea when this will be published? Trying to use in a project. |
ask @guyonroche |
@taoqf @guyonroche It looks like this is in the repo and released 👏 But on v1.0.1 |
@guyonroche , please put index.d.ts in release. |
@ahaverty I found the typings in the repo, copied and pasted into the node_modules/exceljs folder. Not a great solution but works until the release is fixed. |
Before this change I was using types from https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/exceljs Now I updated to the latest exceljs and the 'official' types from this merge don't seem so good. To give one example the font interface says that font requires all the parameters where I believe actually they should be optional? |
@spacem could you please submit a PR that would fix the typing issues you are facing? |
@spacem anything else? |
Beat me to the pr.. Maybe others should be partial but I am not using those. Thanks guys! |
No description provided.