Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the right text out of hyperlinked formula cells #552

Merged
merged 3 commits into from
Apr 30, 2018

Conversation

papandreou
Copy link
Contributor

Turns out we actually had one more patch floating around, sorry :)

This one makes sure that hyperlinked cells that contain a formula will have the right text available.

Previously this test would fail with expected undefined to equal 'someone@example.com'. It appears that there wasn't any way to extract the text contents from those hyperlinked formula cells, except for the hyperlinked url.

holm and others added 3 commits April 25, 2018 10:31
This doesn’t actually work fully, since the parsing ordering is wrong. But this is a step towards support.
@guyonroche guyonroche merged commit a6b18a2 into exceljs:master Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants