Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like 095c82f broke an essential feature of the maxRows PR. It is delaying the teardown of the stream to the next tick by moving it to
promise.catch(...)
here: 095c82f#diff-678e4bd9f1bcf0cc0c17eee7684618abR101That means that the parser will still busyloop on the remaining rows of the current unzipped chunk, which can be quite a lot.
I've added a test with a huge .xlsx that runs for over 30 seconds on my machine, but less than a second when I revert the tidy commit.
I'm not sure exactly how to fix it without essentially reverting most of it, so for now I'm just submitting the test :)