Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some xlsx stream read xlsx not in guaranteed order problem #578

Merged
merged 3 commits into from
Nov 7, 2018
Merged

Fix some xlsx stream read xlsx not in guaranteed order problem #578

merged 3 commits into from
Nov 7, 2018

Conversation

KMethod
Copy link

@KMethod KMethod commented May 30, 2018

when stream read some xlsx files (like numbers convert to xlsx), get values like :
row.values [ ,
{ sharedString: 47 },
{ sharedString: 35 },
{ sharedString: 47 },
{ sharedString: 37 },
{ sharedString: 37 },
{ sharedString: 37 },
{ sharedString: 37 },
{ sharedString: 37 },
{ sharedString: 37 },
]

try to fix this problem

@KMethod KMethod changed the title Fix some xlsx stream read get sharedstring index problem Fix some xlsx stream read xlsx not in guaranteed order problem May 30, 2018
@guyonroche
Copy link
Collaborator

@KMethod my concern with this PR is the use of Temp, which won't work in a browser. The StreamBuf class (in utils) should provide an in-memory alternative

@KMethod
Copy link
Author

KMethod commented Jun 28, 2018

@guyonroche Streaming XLSX are only exposed in NodeJS, so does it matter?

@guyonroche
Copy link
Collaborator

@KMethod Sorry this is dragging out - I don't have a huge amount of time these days.
It might matter - this change puts a dependency on the environment (i.e. temp folders).

I'm still not sure what problem this fix is solving. Can you give more details?

@guyonroche guyonroche merged commit 890c97d into exceljs:master Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants