Stream's eof() function does not return correct result.

[katmsft]

Hi, recently during development I found that the eof() method of StreamInterface does not work properly. I do not know if it is me who misunderstood the behavior or there is a bug regarding this issue. The code of me testing the case is like this.

$resource = fread('test.txt');//Any test txt file. Better not too large.
$content = Psr7\stream_for($resource);
$size = $content->getSize();
$content->read($size);//Read exactly the size of the file.
$isEof = $content->eof() == true? 'is end of file' : 'not end of file';
echo "{$size}\n{$isEof}\n";//Print the size of the file. Result also show 'not end of file';

If I get the remaining contents of the file using getContents or read($length) afterwards it returns an empty string, and then can have eof() returning the correct result.

[Tobion]

This is a known behavior of feof that psr7 is just wrapping around so it inherits the same thing. See comments in http://php.net/manual/en/function.feof.php

[jackbentley]

Note that the PSR interface defines eof() as...

Returns true if the stream is at the end of the stream.

However, the current implementation (and that of feof()) is more akin to...

Returns true if the stream is after the end of the stream.