Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build fail on HHVM 4.0 #260

Closed
bu4ak opened this issue Feb 14, 2019 · 2 comments
Closed

Build fail on HHVM 4.0 #260

bu4ak opened this issue Feb 14, 2019 · 2 comments
Milestone
1.6.0

Comments

@bu4ak
Copy link

bu4ak commented Feb 14, 2019

After I created the PR ( #259 ), I saw that the build ended with an error ( https://travis-ci.org/guzzle/psr7/jobs/492774182 ).
And on master too https://travis-ci.org/Bu4ak/psr7/jobs/493026322 .

I think it happened because of the hhvm updated two days ago ( https://github.com/facebook/hhvm/releases/tag/HHVM-4.0.0 )

And Travis uses it (4.0.0) instead of the previous one (3.30.3), because the version in the config is not specified.
@bu4ak
Copy link
Author

bu4ak commented Feb 18, 2019

composer/composer#7990

We need to specify the version or delete the step hhvm

@sagikazarmark
Copy link
Member

Thanks @bu4ak . We are aiming to drop HHVM support, so #262 should fix the problem.

@sagikazarmark sagikazarmark mentioned this issue Feb 20, 2019
Merged
@sagikazarmark sagikazarmark added this to the 1.6.0 milestone Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
2 participants
@sagikazarmark @bu4ak