Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial 1.1 Quiz #5

Open
adivijaykumar opened this issue May 2, 2020 · 3 comments
Open

Tutorial 1.1 Quiz #5

adivijaykumar opened this issue May 2, 2020 · 3 comments

Comments

@adivijaykumar
Copy link
Collaborator

The last question in the quiz for Tut 1.1 asks for a URL to the GW170817 data.

The following code

from gwosc.locate import get_event_urls
urls = get_event_urls('GW170817', duration=4096, detector='V1')
print(urls)

returns https://www.gw-osc.org/catalog/GWTC-1-confident/data/GW170817/L-L1_GWOSC_4KHZ_R1-1187008867-32.hdf5 as the link while the 'correct' link given in the quiz is https://www.gw-openscience.org/eventapi/json/GWTC-1-confident/GW170817/v3/V-V1_GWOSC_4KHZ_R1-1187006835-4096.hdf5.

cc - @camurria, @jkanner

@jkanner
Copy link
Contributor

jkanner commented May 5, 2020

I think Agata's catch of different versions of GWOSC resolves this issue. Using an updated version of the gwosc python package (0.5.3) should give the correct link, which matches what's in the quiz.

@jkanner
Copy link
Contributor

jkanner commented May 5, 2020

Having said that, the quiz supports multiple correct answers. @adivijaykumar I recommend you update the quiz so that both answers will be marked "correct".

@camurria
Copy link
Collaborator

camurria commented May 5, 2020

yes, I think it should be due to the gwosc version. I have the version 0.5.3 and I double checked that if I run the python code @adivijaykumar copied, I get the link: https://www.gw-openscience.org/eventapi/json/GWTC-1-confident/GW170817/v3/V-V1_GWOSC_4KHZ_R1-1187006835-4096.hdf5
I agree that we should add both answers to be conservative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants