Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyGRB workflow open points #4430

Closed
1 of 3 tasks
pannarale opened this issue Jul 10, 2023 · 1 comment
Closed
1 of 3 tasks

PyGRB workflow open points #4430

pannarale opened this issue Jul 10, 2023 · 1 comment
Assignees
Labels
PyGRB PyGRB development

Comments

@pannarale
Copy link
Contributor

pannarale commented Jul 10, 2023

#4288 was merged but a few discussion points from this PR should be tracked. Namely

  • new_snr_chisq in pycbc_pygrb_plot_chisq_veto returns the chi-square value needed to weight SNR into new SNR. Should it be moved to pycbc/events/coherent.py or pycbc/events/ranking.py eventually? It basically inverts get_new_snr from ranking.py with the caveat that the chi-square is set to a small non-zero number, when it should be zero, because pycbc_pygrb_plot_chisq_veto produces log-log plots so we are staying away from zeros. If anyone were to use new_snr_chisq in another context, this could be a problem, but I can always add a keyword argument to get around this.
  • pp_files handling in pycbc_make_offline_grb_workflow. Quoting @spxiwh

I think it's a bad idea to assume anything about the order here, especially things like [-1] or [-2]. The FileLists were never intended to have a special order. That said, the case of a job that produces multiple output files was never supported well, and dealing with cases like this is ugly ..... Suggestions for improvement here are welcome!
However, I would suggest using one of the methods of the FileList class (https://pycbc.org/pycbc/latest/html/_modules/pycbc/workflow/core.html#FileList) to get these files. It's possible that a new method will be needed, as I think you'll want to search by "description", rather than "tag" (but I'm not sure). I think that file_list. categorize_by_attr('description') may produce what @titodalcanton suggests ... and would then be easier and clearer to work with.

@pannarale pannarale added the PyGRB PyGRB development label Jul 10, 2023
@pannarale pannarale self-assigned this Jul 10, 2023
@pannarale pannarale mentioned this issue Apr 23, 2024
22 tasks
@pannarale
Copy link
Contributor Author

The remaining issues are not about pycbc_make_offline_grb_workflow itself so they were moved to issue #4703.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyGRB PyGRB development
Projects
Status: Done
Development

No branches or pull requests

1 participant