Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HFile select function updates #4524

Closed
GarethCabournDavies opened this issue Oct 9, 2023 · 2 comments
Closed

HFile select function updates #4524

GarethCabournDavies opened this issue Oct 9, 2023 · 2 comments

Comments

@GarethCabournDavies
Copy link
Contributor

The select function in HFile should be able to use any sngl-ranking statistic directly.

We should also be able to return indices-only, rather than just values, or indices-and-values as is the case now

To use the above selection, we should make sure we are efficient with the code, not reading in additional datasets which are not needed.

  • I think we could do this by having a dictionary in ranking.py which stores which datasets are used by each statistic. That list can be used as a reference in this function.

mask_loudest_to_n_triggers should have the same functionality, acting on triggers rather than the file though

@GarethCabournDavies
Copy link
Contributor Author

Ian pointed out that sometimes datasets aren't made if they aren't requested in the inspiral jobs - the 'used_datasets' dictionary should be able to handle this, but we should make sure of this

@GarethCabournDavies
Copy link
Contributor Author

This is fully implemented now, so can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant