Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request -- Optional compiler flags in SuperDevMode #7711

Open
dankurka opened this issue Jun 10, 2015 · 7 comments
Open

Feature Request -- Optional compiler flags in SuperDevMode #7711

dankurka opened this issue Jun 10, 2015 · 7 comments
Assignees

Comments

@dankurka
Copy link
Contributor

Originally reported on Google Code with ID 7714

The ability to set flags like "-strict", "-logLevel" etc... for every re-compile in
SuperDevMode would greatly enhance the debugging experience.


Found in GWT Release (e.g. 2.4.0, 2.5.0 RC):
2.5.0 RC1  2.5.0 RC2


Detailed description (please be as specific as possible):

In order to be able to set compiler flags on re-compile I propose a SuperDevMode CUI
change from https://docs.google.com/open?id=0B6TyFaNg6UEDY2tPOE40RGp3Vnc to https://docs.google.com/open?id=0B6TyFaNg6UEDcDhkZm82cjc0Wms.
Or similar ;)


Workaround if you have one:

My current workflow is to recompile the gwt-codeserver.jar and hardcode my desired
flags into http://code.google.com/p/google-web-toolkit/source/browse/trunk/dev/codeserver/java/com/google/gwt/dev/codeserver/CompilerOptionsImpl.java.

Links to relevant GWT Developer Forum posts:

See discussion on this topic : https://groups.google.com/d/topic/Google-Web-Toolkit/wGah17T4jxY/discussion.

Link to patch posted at http://gwt-code-reviews.appspot.com:
I will try to submit a patch October 7th.

Reported by okrylow on 2012-10-05 09:57:43

@dankurka
Copy link
Contributor Author

Yes, of course we should do this.

I was also thinking that compiler flags should be in the web UI somewhere, so you could
change them and recompile to see what the difference is, without restarting Super Dev
Mode. But that doesn't have to be done now.


Reported by skybrian@google.com on 2012-10-09 20:27:30

  • Status changed: Accepted
  • Labels added: Category-SuperDevMode

@dankurka
Copy link
Contributor Author

Hi!

I am in the process of patching this right now. October the 7th was too optimisitc
by me :), this will take a little bit longer. But I managed to get the gwt sources
compiled and tested. Since I am using eclipse I also created a eclipse project for
codeserver in GWT_ROOT/eclipse.

"But that doesn't have to be done now."

Do you mean google has higher priorities inside codeserver or do you have plans for
major restructuring of codeserver?


Reported by okrylow on 2012-10-09 21:21:35

@dankurka
Copy link
Contributor Author

please make command line options first - that is fine compared to having to patch and
recompile.   UI would be nice, but no "-strict" is a real pain.  

Reported by carchrae on 2012-11-07 22:40:41

@dankurka
Copy link
Contributor Author

Note: -logLevel has been added to the command-line options. See issue 8472

Reported by t.broyer on 2014-02-25 17:09:35

@dankurka
Copy link
Contributor Author

-strict (also known as -failOnError) has been committed to trunk. See: https://gwt-review.googlesource.com/#/c/6981/



Reported by skybrian@google.com on 2014-04-11 18:15:31

@dankurka
Copy link
Contributor Author

Any other option we'd want to add? Maybe we can close the issue?

Reported by t.broyer on 2014-04-12 02:34:22

@dankurka
Copy link
Contributor Author

It's less urgent but I think we might want to allow various optimizations to be turned
on, so you can see their effects.

Reported by skybrian@google.com on 2014-04-22 22:12:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant