Assertion in 'do_send' (quicly.c)

[dmat93]

Hi,
during some tests I got this error

qperf: /root/qperf/extern/quicly/lib/quicly.c:4346: do_send: Assertion `min_packets_to_send <= s->max_datagrams' failed.

that I solved by setting the min_packets_to_send = 1 instead of min_packets_to_send = 0 . I am pretty sure that it can be fixed also by putting assert(min_packets_to_send < s->max_datagrams)

Can you inspect this error and validate the solution?

Thanks

[ghost]

+1

[ogkloo]

I had this error come up recently. I tried changing <= to < in assert(min_packets_to_send <= s->max_datagrams) but it didn't seem to work. Still not sure what's up with it.

[ankitkat042]

Can anyone explain what is the point of assert(min_packets_to_send < s->max_datagrams) as it is giving error in qperf implementation(though it uses very old version of quicly. I tried commenting out the line and It worked for me.
here is the line