peer_addr = null when doing directed advertising

[ViktorRindom]

When I do "BLE_GAP_CONN_MODE_UND" everything works but when I change to "BLE_GAP_CONN_MODE_DIR" I always get the error "Unable to advertise - Duration too long". I have found out that this is a result of the rc value of 3 (BLE_HS_EINVAL). This error code is used in a lot of places and I started replacing the values with my own unique error codes and found out that my error was peer_addr being null in the file ble_gap.c in the function ble_gap_adv_validate. But i cant fix this since the file NimBLEAdvertising.cpp puts null in the call ble_gap_adv_start.

TLDR: NimBLEAdvertising.cpp sets peer_addr to null and ble_gap.c returns an error if peer_addr is null

[ViktorRindom]

the line with null:

NimBLE-Arduino/src/NimBLEAdvertising.cpp

Line 627 in 0d9f039

rc = ble_gap_adv_start(NimBLEDevice::m_own_addr_type, NULL, duration,

the line with null check:

NimBLE-Arduino/src/nimble/nimble/host/src/ble_gap.c

Line 2614 in 0d9f039

if (peer_addr == NULL) {

[h2zero]

Thanks for bringing this up, a new parameter should be added to advertising start in this case that takes the address.

[ViktorRindom]

Is it possible to do directed advertise to a list and not a single peer_addr?

[h2zero]

Only a single address can be directly advertised to.

[ViktorRindom]

It would also be nice if all errors did not use rc code 3

[ViktorRindom]

@h2zero will you write here when the bug is fixed?
So we can close this issue and so I can update to the fix?

[h2zero]

@ViktorRindom please check #507 and let me know if this works for you.

[ViktorRindom]

@h2zero Im using Platformio how do I use the pull request version of the library?

[h2zero]

You can just use the branch name: lib_deps = https://github.com/h2zero/NimBLE-Arduino.git#bugfix-directed-adv