Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing infos in 1.x_to2.x_migration_guide #844

Open
sepp89117 opened this issue Jan 6, 2025 · 1 comment
Open

Missing infos in 1.x_to2.x_migration_guide #844

sepp89117 opened this issue Jan 6, 2025 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@sepp89117
Copy link

Hi,

I noticed during the migration of a project that the following is not included in the migration guide:

  • NimBLEDevice::getClientByID(uint16_t conn_id); changed to NimBLEDevice::getClientByHandle(uint16_t connHandle)
  • NimBLEScan::setAdvertisedDeviceCallbacks(NimBLEAdvertisedDeviceCallbacks* pAdvertisedDeviceCallbacks, bool wantDuplicates = false) changed to NimBLEScan::setScanCallbacks(NimBLEScanCallbacks* pScanCallbacks, bool wantDuplicates = false);

Hope this helps
Best regards

@h2zero
Copy link
Owner

h2zero commented Jan 7, 2025

Thanks, lots of changes happened and it's not easy to document them all sometimes. I'll look to do a docs update soon.

@h2zero h2zero added the documentation Improvements or additions to documentation label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants