Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for non-encrypted data in same secret #409

Open
tooptoop4 opened this issue Nov 28, 2022 · 6 comments
Open

support for non-encrypted data in same secret #409

tooptoop4 opened this issue Nov 28, 2022 · 6 comments

Comments

@tooptoop4
Copy link

tooptoop4 commented Nov 28, 2022

would be great to support another section for unencrypted data, ie plaintext username that is associated with a password

ie

apiVersion: secret.h3poteto.dev/v1beta1
kind: KMSSecret
metadata:
  name: test1sec
  namespace: testing
spec:
  data:
    USER: my_db_username
  encryptedData:
    PASSWORD: AQICAHh2iCEGE2e6vdC+w6dQ4hRIyahEPE...

also could support https://jamesdefabia.github.io/docs/user-guide/kubectl/kubectl_create_secret_docker-registry/

@tooptoop4
Copy link
Author

what do u think @h3poteto ?

@h3poteto
Copy link
Owner

h3poteto commented Jan 10, 2023

If you don't need to encrypt the username, you should not use Secret for it, I think.

@tooptoop4
Copy link
Author

they are a combo, password is not useful without knowing what user its for. if they both in the secret then many objects can simply refer to the secret

@h3poteto
Copy link
Owner

If so, why not encrypt the username as well?

@tooptoop4
Copy link
Author

its not sensitive, problem is then can't find username by searching source code

@h3poteto
Copy link
Owner

I have no intention of implementing such a feature in this controller.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants