Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getNotifications type : "achievementEarned" not worked for misskey v13 #1591

Closed
potproject opened this issue Feb 17, 2023 · 1 comment
Closed

Comments

@potproject
Copy link
Contributor

potproject commented Feb 17, 2023

The misskey v13 implementation of the "achievementEarned" type returns the user as null, so when getNotifications is used, an error occurs in this code section.

null is not an object (evaluating 'u.username')

https://github.com/h3poteto/megalodon/blob/master/megalodon/src/misskey/api_client.ts#L53

API Response:

[
{
    "id":"9bbz9taaoq",
    "createdAt":"2023-02-17T10:54:14.914Z",
    "type":"achievementEarned",
    "isRead":true,
    "userId":null,
    "user":null,
    "achievement":"login3"
},
...
]

image

@h3poteto
Copy link
Owner

refs: #1669

@h3poteto h3poteto closed this as not planned Won't fix, can't repro, duplicate, stale Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants