Move font-size delaration to html element #1411
Closed
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since rems are based on the
font-size
of the html element we should probably move thefont-size
declaration there. This would set up reasonable expectations for the developer (editfont-size
, change rems) without changing any current behavior (body { font-size: 1em }
is implied).The original commit to add
body { font-size: 1em }
is here. It seems it was added as a developer convenience, whileline-height
needed normalization.