-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add /.editorconfig
#1564
Add /.editorconfig
#1564
Conversation
[*] | ||
charset = utf-8 | ||
end_of_line = lf | ||
indent_style = tab |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Try it now, @alrra. |
I +1 on merging this since I am a big fan of consistency. EditorConfig adds this. For v6 this project could totally become a bit more of an extended template which integrates some more opinionated features which the community thinks are good and somewhat stable and established. |
@jonathantneal LGTM, however, we should also add a few lines in the docs about it (including a note about the disclosure issue). I'm also ok with this addition, and now, since it works with quite a few editors, I think it can be useful. |
What do you think of the following documentation? EDIT: Removed |
@jonathantneal can you add this to the commit, it is easier to review that way as comments can be added to specific lines. :) |
``` | ||
|
||
* EditorConfig homepage: [http://editorconfig.org/](http://editorconfig.org/) | ||
* Projects using EditorConfig: [//github.com/editorconfig/editorconfig/wiki/Projects-Using-EditorConfig](//github.com/editorconfig/editorconfig/wiki/Projects-Using-EditorConfig) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
@alrra, updated. |
trim_trailing_whitespace = true | ||
|
||
[*.md] | ||
trim_trailing_whitespace = false |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Documentation
@alrra, updated. |
If there will be package.json, bower.json, .travis.yml and similar files, it would be nice to have [{bower.json,package.json,.travis.yml}]
indent_style = space
indent_size = 2 |
@koistya if we ever provide those files, we will certainly add those properties, otherwise will just include the bare minimum and let users change and add new properties according to their needs.
Thank you @jonathantneal! 💜 I'll leave this open for a few more days so that people have the chance to state their opinion. |
The addition of the `/.editorconfig` file is made in order to encourage and help developers and their teams define and maintain consistent coding styles between their different editors and IDEs. By default, the `/.editorconfig` file includes some default properties that apply to the coding styles used by HTML5 Boilerplate, but users can easily change them to better suit their needs. Since users need to install a editor/IDE plugin in order for the properties from the `/.editorconfig` to be applied, we were reluctant to add this file in the past (see: #1124). Nowadays however, the EditorConfig project provides plugins for most of the popular editors/IDEs (see: http://editorconfig.org/#download), plus, more and more developers are using it. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Ref: http://editorconfig.org/ Close: #1561 #1564
The addition of the `/.editorconfig` file is made in order to encourage and help developers and their teams define and maintain consistent coding styles between their different editors and IDEs. By default, the `/.editorconfig` file includes some default properties that apply to the coding styles used by HTML5 Boilerplate, but users can easily change them to better suit their needs. Since users need to install a editor/IDE plugin in order for the properties from the `/.editorconfig` to be applied, we were reluctant to add this file in the past (see: #1124). Nowadays however, the EditorConfig project provides plugins for most of the popular editors/IDEs (see: http://editorconfig.org/#download), plus, more and more developers are using it. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Ref: http://editorconfig.org/ Close: #1561 #1564
|
||
[*] | ||
charset = utf-8 | ||
end_of_line = lf |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
👍 I find editorconfig very useful. We have it included in our Yeoman generators and Web Starter Kit. |
+1 Even if people don't use editors supporting/using the .editorconfig file it's still a nice way of documenting how certain files should be formatted. Definitely include it! :) |
I've asked people on Twitter what they think about this addition, and since some of them prefer to respond there, here is the link to the tweet: https://twitter.com/h5bp/status/490559737667149824. |
+1 for editorconfig |
+1 for it. Using it in all my projects very helpful. |
+1 for adding it |
👍 |
As a Windows user I don't personally see any problems with 👍 |
I personally sort these parameters by "importance" - the most important is space/tabs and how many spaces for indentation.
|
👍 |
root = true | ||
|
||
[*] | ||
charset = utf-8 |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Enough »chit chat«. Merge that in. 👍 People who are already using a editor config plugin will be able to adapt the People who don’t know editor config could ignore this file. But I guess it will spread the usage of editor config and will make the world a better place |
What's the reason for I'd also question |
Regarding
|
@koistya Importance is kinda subjective, so let's just stick to alphabetical order.
@dustinhorton We currently use 4 spaces throughout the code. @jonathantneal Merged with some modifications in a99d856 Thanks everyone for the feedback, we sincerely appreciate it! :) |
The addition of the `/.editorconfig` file is made in order to encourage and help developers and their teams define and maintain consistent coding styles between their different editors and IDEs. By default, `/.editorconfig` includes some basic properties that reflect the coding styles from the files provided by default, but users can easily change them to better suit their needs. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Since users need to install a editor/IDE plugin in order for the properties from the `/.editorconfig` to be applied, we were reluctant to add this file in the past (see: #1124). Nowadays however, the EditorConfig project provides plugins for most of the popular editors/IDEs (see: http://editorconfig.org/#download), plus, more and more developers are using it. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Ref: http://editorconfig.org/ Close: #1561 #1564
The addition of the `/.editorconfig` file is made in order to encourage and help developers and their teams define and maintain consistent coding styles between their different editors and IDEs. By default, `/.editorconfig` includes some basic properties that reflect the coding styles from the files provided by default, but users can easily change them to better suit their needs. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Since users need to install a editor/IDE plugin in order for the properties from the `/.editorconfig` to be applied, we were reluctant to add this file in the past (see: h5bp/html5-boilerplate#1124). Nowadays however, the EditorConfig project provides plugins for most of the popular editors/IDEs (see: http://editorconfig.org/#download), plus, more and more developers are using it. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Ref: http://editorconfig.org/ Close: h5bp/html5-boilerplate#1561 h5bp/html5-boilerplate#1564
See: http://editorconfig.org/