Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task to use Requirejs for js optimization #36

Merged
merged 2 commits into from
May 1, 2012
Merged

Task to use Requirejs for js optimization #36

merged 2 commits into from
May 1, 2012

Conversation

EpocSquadron
Copy link
Contributor

This is the bare bones grunt task file and some init task changes to start the integration into node build script. This will need a little additional work with respects to integrating the task into targets for grunt build.

@EpocSquadron
Copy link
Contributor Author

:-) Pull request submitted. Depending on how much time I have this week I might be able to contribute the neccesary target integration.

@mklabs
Copy link
Owner

mklabs commented Apr 30, 2012

Great! I'll play with it and merge into dev, most likely tomorrow.

Would you like me to hold off the pull request a little bit so that you can still attach commits for this target integration?

To me, it looks good. Maybe just a few notes in the docs on how to enable rjs optimizer and how to integrate in the overall build process would be enough. Anyway.. Thanks!

@paulirish
Copy link
Contributor

👍

@EpocSquadron
Copy link
Contributor Author

I most likely won't be able to make the time to finish those tasks today, so you can go ahead with merge when you're ready.

@mklabs
Copy link
Owner

mklabs commented May 1, 2012

No worries :) I'll do during the day. If you'd like to bring some tweaks, this can definitely be done with other PR as you see fit.

I'll rework the test/ directory in the meantime, this should be easier to add more tests for a given task. Probably by setting up convenience scripts to generate new ones.

@mklabs
Copy link
Owner

mklabs commented May 1, 2012

Edit: I'll do right away. This is super clean, I might add some editions later on.

mklabs added a commit that referenced this pull request May 1, 2012
Task to use Requirejs for js optimization
@mklabs mklabs merged commit 1121148 into mklabs:dev May 1, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants