Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change examples to track the master branch #228

Open
krnowak opened this issue Mar 29, 2018 · 6 comments
Open

Change examples to track the master branch #228

krnowak opened this issue Mar 29, 2018 · 6 comments

Comments

@krnowak
Copy link
Contributor

krnowak commented Mar 29, 2018

Recently we have changed habitat-operator to use stateful sets instead of deployments. A part of the change was to update the rbac rules in examples/rbac/rbac.yml. But examples/rbac/habitat-operator.yml still points to a docker image that contains that handles deployments. So after applying the manifests in examples/rbac we are going to get permission errors because the old operator can't do anything with deployments anymore.

So I was wondering if we should use a latest tag in our examples and on every change in master branch, we should build the docker image and push it to the docker registry with latest tag.

That would likely require a new step in our release process - after a release is done, we change all the manifests in examples, so they use habitat/habitat-operator:latest.

Not sure if we should do the same for helm charts.

@krnowak
Copy link
Contributor Author

krnowak commented Mar 29, 2018

I'm not sure whether to put it in the project board.

@asymmetric
Copy link
Contributor

I'm not sure whether to put it in the project board.

Why not?

@krnowak
Copy link
Contributor Author

krnowak commented Apr 3, 2018

I basically thought that project board is a board of issues that we need to work on, and I feel that this issue is more or less a request for enhancement.

@asymmetric
Copy link
Contributor

I think it belongs in the board, and it can be tagged with "enhancement".

@asymmetric
Copy link
Contributor

To the point of the issue: I think the way we do it now is that we update the examples once we release a new version.

Basically, right now running the examples from the master branch is broken, because the operator is out of date.

after a release is done, we change all the manifests in examples, so they use habitat/habitat-operator:latest

I don't get this. With your change, there is nothing to change in the manifests, because they already use latest. What there is to do is push the docker tag latest.

I think it's a good idea btw.

@krnowak
Copy link
Contributor Author

krnowak commented Apr 4, 2018

When we do a release, I would like the examples to use the properly tagged docker images. And after we do git tag on the commit, we revert back to using latest. This is to have examples in the release tarball (or zip) to use properly tagged docker images, not latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants