-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change examples to track the master branch #228
Comments
I'm not sure whether to put it in the project board. |
Why not? |
I basically thought that project board is a board of issues that we need to work on, and I feel that this issue is more or less a request for enhancement. |
I think it belongs in the board, and it can be tagged with "enhancement". |
To the point of the issue: I think the way we do it now is that we update the examples once we release a new version. Basically, right now running the examples from the
I don't get this. With your change, there is nothing to change in the manifests, because they already use I think it's a good idea btw. |
When we do a release, I would like the examples to use the properly tagged docker images. And after we do |
Recently we have changed habitat-operator to use stateful sets instead of deployments. A part of the change was to update the rbac rules in
examples/rbac/rbac.yml
. Butexamples/rbac/habitat-operator.yml
still points to a docker image that contains that handles deployments. So after applying the manifests inexamples/rbac
we are going to get permission errors because the old operator can't do anything with deployments anymore.So I was wondering if we should use a
latest
tag in our examples and on every change in master branch, we should build the docker image and push it to the docker registry withlatest
tag.That would likely require a new step in our release process - after a release is done, we change all the manifests in examples, so they use
habitat/habitat-operator:latest
.Not sure if we should do the same for helm charts.
The text was updated successfully, but these errors were encountered: