Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container Exporter: Stop allowing channel as a parameter in custom tags #7695

Open
christophermaier opened this issue May 18, 2020 · 2 comments

Comments

@christophermaier
Copy link
Contributor

christophermaier commented May 18, 2020

Hypothesis: the fact that the channel a particular Habitat package is currently in is not an intrinsic part of that package, and thus should not be provided as a parameter for creating a custom tag at container export time.

Furthermore, tags in Docker and channels in Builder are different enough that we probably shouldn't be conflating them (the "latest" tag in Docker is the closest thing to a "channel" that I can see).

Until Builder gets the ability to map promotions to container repository retaggings (as alluded to in habitat-sh/builder#376), we probably should not muddy the waters. It seems like if users want to reflect their Builder channels in their container repository tags, that is something best left to external tooling at the current time.

I think having channel as an option in our custom tagging scheme is confusing and potentially harmful, and should be removed. If there are dissenting voices on this topic, however, I would love to hear 🙇 😄

Aha! Link: https://chef.aha.io/features/APPDL-114

@stale
Copy link

stale bot commented May 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you.

@stale
Copy link

stale bot commented Jun 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you.

@stale stale bot added the Stale label Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants