Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation bar contents not visible #20

Open
geekayush opened this issue Aug 1, 2019 · 5 comments
Open

Navigation bar contents not visible #20

geekayush opened this issue Aug 1, 2019 · 5 comments
Labels
bug Something isn't working

Comments

@geekayush
Copy link

When the carousel gets a background with light colors, the links being white are not visible to eyes.
I would suggest adding a grey gradient to it. So that navigation bar gets independent of the background of the carousel.

@mooocer
Copy link
Member

mooocer commented Aug 1, 2019

Thanks @geekayush for pointing this out. I had the same gradient solution in mind. There's already an open PR #18 by @aniruddhparwal for the same issue, though his solution isn't good.

He is out currently and will return after a week. So if you'd like you can take it up :)

@geekayush
Copy link
Author

Okay. Would giving it a grey color with some box-shadow be fine?

@mooocer
Copy link
Member

mooocer commented Aug 2, 2019

Yeah sure, go ahead :) 👍

@mooocer
Copy link
Member

mooocer commented Aug 2, 2019

@mooocer mooocer added the bug Something isn't working label Aug 23, 2019
@mooocer
Copy link
Member

mooocer commented Aug 27, 2019

@geekayush do you plan to continue work on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants