Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the type in yorkie-sdk-js #110

Open
ppeeou opened this issue May 11, 2021 · 2 comments
Open

Use the type in yorkie-sdk-js #110

ppeeou opened this issue May 11, 2021 · 2 comments

Comments

@ppeeou
Copy link
Contributor

ppeeou commented May 11, 2021

Description:
Use the type provided by yorkie-js-sdk

Why:
we can code by knowing the parts provided by yorkie-js-sdk better.

@hackerwins hackerwins added this to v0.2 Oct 29, 2021
@hackerwins hackerwins moved this to Todo in v0.2 Oct 29, 2021
@hackerwins hackerwins removed this from v0.2 Dec 14, 2021
@hackerwins hackerwins added this to v0.3 Dec 14, 2021
@hackerwins hackerwins moved this to Todo in v0.3 Dec 14, 2021
@mu-hun
Copy link
Contributor

mu-hun commented Jul 27, 2022

I'm interested in this issue, and it seems to be using the type definitions defined from yorkie-js-sdk module just fine.

but I still don't understand what needs to be changed. 🤔 👀

@ppeeou
Copy link
Contributor Author

ppeeou commented Jul 27, 2022

@x86chi
Previously, the methods provided in the SDK did not match the methods we were actually using.

Related issues
yorkie-team/yorkie-js-sdk#205 (comment)

Solved PR
yorkie-team/yorkie-js-sdk#289
yorkie-team/yorkie-js-sdk#300
yorkie-team/yorkie-js-sdk#299

Currently, the provided methods are matched all what we use
https://yorkie.dev/yorkie-js-sdk/yorkie-js-sdk.jsonarray.html

so I think it is better to use a combination of generics and sdk methods without defining types in codepair anymore.
https://github.com/yorkie-team/codepair/blob/main/src/features/docSlices.ts#L71

@hackerwins hackerwins removed this from v0.3 Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants