Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Contact Form layout on Contact Us page #1659

Closed
6 tasks done
Skydodle opened this issue Jan 26, 2024 · 2 comments · Fixed by #1670
Closed
6 tasks done

Fix Contact Form layout on Contact Us page #1659

Skydodle opened this issue Jan 26, 2024 · 2 comments · Fixed by #1670
Assignees
Labels
P-feature: Contact Us Pre-Launch Describes an issue that must be completed in order to launch Role: Frontend React front end work Size: 1pt Can be done in 6 hours

Comments

@Skydodle
Copy link
Member

Skydodle commented Jan 26, 2024

Overview

On the Contact Us page, the current contact form's styling does not match our Figma design. We need to update the form's styling and layout to match the Figma design in preparation for pre-launch.

Action Items

  • Inspect the screenshots of 'current layout' & 'expected layout' below in Resources/Instructions to compare the visual difference on the forms
  • Review the Figma design file in Figma Resources below to inspect the CSS layout requirements such as properties for each input field on the contact form
  • Review the ContactForm.jsx component in codebase
  • If needed, familiarize yourself with MUI Components documentation specifically on Grids and Forms
  • Make changes to the codebase so that our contact form match with the Figma design
  • Test the changes to confirm it's bug free prior to pushing and making a pull request

Resources/Instructions

Screenshot of current layout

Screenshot 2024-01-27 at 12 18 45 AM

Screenshot of expected layout (from Figma)

Screenshot 2024-01-27 at 12 28 17 AM


Note: just work on the form for this issue, ignore the other design differences on the page for now

Screenshot 2024-01-27 at 12 25 03 AM

Figma Resources

@Skydodle Skydodle added Size: 1pt Can be done in 6 hours P-feature: Contact Us Milestone: Missing ready for dev lead ready for developer lead to review the issue Pre-Launch Describes an issue that must be completed in order to launch draft labels Jan 26, 2024
@Skydodle Skydodle changed the title Fix Contact Form display on Contact Us page Fix Contact Form layout on Contact Us page Jan 26, 2024
@ryanfchase
Copy link
Member

@Skydodle this looks like sufficient detail for a dev to get started. I'm going to take off the ready for dev and draft label and put this in Prioritized Backlog so it can be assigned.

Also - the Pre-Launch label is a good idea, but PMs were reluctant to implement this and instead preferred to go with tracking via the Epic of Epics. I'll leave the label here in case we decide we want to add Pre-Launch to all other tickets later 😄

@ryanfchase ryanfchase added Role: Frontend React front end work and removed draft ready for dev lead ready for developer lead to review the issue labels Jan 26, 2024
@bphan002 bphan002 self-assigned this Jan 31, 2024
@bphan002
Copy link
Member

ETA: Monday, February 5
Availability: Saturday, February 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-feature: Contact Us Pre-Launch Describes an issue that must be completed in order to launch Role: Frontend React front end work Size: 1pt Can be done in 6 hours
Projects
Status: Done (without merge)
3 participants