Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Loading Modals (Dev) #1676

Closed
7 tasks done
cottonchristopher opened this issue Feb 11, 2024 · 2 comments · Fixed by #1706
Closed
7 tasks done

Update Loading Modals (Dev) #1676

cottonchristopher opened this issue Feb 11, 2024 · 2 comments · Fixed by #1706
Assignees
Labels
P-feature: Map Pre-Launch Describes an issue that must be completed in order to launch Role: Frontend React front end work Size: 2pt Can be done in 7-12 hours
Milestone

Comments

@cottonchristopher
Copy link
Member

cottonchristopher commented Feb 11, 2024

Overview

We need to implement a loading modal that clarifies who our organization is while also cueing the user that data is still being loaded because the current implementation is ambiguous.

Action Items

  • Modify the FactModal to make use of a click-trap (no clicking out)
  • Adjust the modal backdrop to match the new Figma design
  • Add another div to the FactModal component that will contains the 311 logo, loading gif, about-us blurb, and modal-footer
  • Add a new state, prop, and callback for when the data is loaded in, e.g. onDataLoaded, ensure that the modal changes according to the design flow
  • Add a div that renders when the data is loaded which contains the header, 311 blurb, and OK button
  • Ensure that the modal remains open until the data has loaded, only closing when they click "OK"
  • (optional) Rename FactModal to LoadingModal, or some other name that indicates that more than fun facts are being communicated on the modal

Resources/Instructions

Screenshot of Figma Section

Loading Modal for Handoff 02 28 2024

@cottonchristopher cottonchristopher added Role: Frontend React front end work Size: Missing P-feature: Map ready for dev lead ready for developer lead to review the issue draft labels Feb 11, 2024
@cottonchristopher cottonchristopher added this to the 04 - Map Page milestone Feb 11, 2024
@cottonchristopher
Copy link
Member Author

cottonchristopher commented Feb 11, 2024

After reviewing/estimating prelaunch tickets and time to launch PM's saw the need for an additional ticket related to another issue. #1655
Can we have Dev/Front-End team to complete the above ticket that has been started, adding/correcting information on the ticket/issue and indicate "size", etc.?.

@bberhane bberhane added the Pre-Launch Describes an issue that must be completed in order to launch label Feb 21, 2024
@ryanfchase ryanfchase added Size: 2pt Can be done in 7-12 hours and removed Size: Missing labels Mar 7, 2024
@ryanfchase ryanfchase assigned ryanfchase and unassigned ryanfchase Mar 7, 2024
@Skydodle Skydodle self-assigned this Mar 9, 2024
@Skydodle Skydodle removed ready for dev lead ready for developer lead to review the issue draft labels Mar 9, 2024
@Skydodle Skydodle assigned Skydodle and unassigned Skydodle Mar 9, 2024
@Skydodle
Copy link
Member

Skydodle commented Mar 9, 2024

Availability: M-F after 7pm PST
Completion ETA: Before 3/20 EOD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-feature: Map Pre-Launch Describes an issue that must be completed in order to launch Role: Frontend React front end work Size: 2pt Can be done in 7-12 hours
Projects
Status: Done (without merge)
Development

Successfully merging a pull request may close this issue.

4 participants