Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make date range textboxes clickable in Search and Filters modal #1806

Closed
3 tasks
ryanfchase opened this issue Sep 1, 2024 · 4 comments · Fixed by #1826
Closed
3 tasks

Make date range textboxes clickable in Search and Filters modal #1806

ryanfchase opened this issue Sep 1, 2024 · 4 comments · Fixed by #1826
Assignees
Labels
Milestone

Comments

@ryanfchase
Copy link
Member

ryanfchase commented Sep 1, 2024

Overview

Based on usability testing, we want to make the date range text boxes function similarly to the calendar dropdown button so that users can access the calendar more easily.

Action Items

  • Modify DatePicker to add on-click functionality to the Selected Days textboxes
  • Modify the cursor type to be cursor: pointer when hovering over Selected Days textboxes
  • Provide SCREEN RECORDING of date range textboxes causing the date picker to appear

Resources/Instructions

Important Components & Files

  • DateSelector: components/DateSelector/DateSelector.jsx
  • DatePicker: components/common/DatePicker/DatePicker.jsx
    • consider adding on-click functionality to L115: (see below)
    • consider the existing calendar toggle method: toggleCalendar, defined on L109 and used on L119 in <IconButton/>

L115 of DatePicker.jsx:

  <div>{renderSelectedDays([startDate, endDate], classes, range)}</div>
Screenshot before proposed changes

Date range text boxes can be highlighted, but do not contain functionality

image

SCREEN RECORDING of proposed changes

[TODO: insert screen capture here]

@ryanfchase
Copy link
Member Author

@palakkeni5 thank you for getting started on this. Can you leave a comment with the following info:

  • your ETA (feel free to give a generous estimate since this is your first ticket)
  • your availability (e.g. when can we reach you for comment/discussion on this ticket)

Thanks, happy coding

@palakkeni5 palakkeni5 removed their assignment Sep 4, 2024
@ryanfchase ryanfchase moved this from In progress to Prioritized Backlog (ready to be assigned) in P: 311: Project Board Sep 7, 2024
@DorianDeptuch DorianDeptuch moved this from Prioritized Backlog (ready to be assigned) to In progress in P: 311: Project Board Sep 7, 2024
@DorianDeptuch DorianDeptuch self-assigned this Sep 7, 2024
@DorianDeptuch
Copy link
Member

ETA: Friday, September 13th
Availability: Weekday Evenings 7pm-11pm

@DorianDeptuch
Copy link
Member

The PR for this issue can be found here: #1826

@ryanfchase @traycn

@DorianDeptuch DorianDeptuch moved this from In progress to In Review in P: 311: Project Board Sep 15, 2024
@ryanfchase
Copy link
Member Author

@DorianDeptuch we'll just do 1 approval for your PR. You're good to merge when ready 👍

@github-project-automation github-project-automation bot moved this from In Review to Done (without merge) in P: 311: Project Board Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done (without merge)
Development

Successfully merging a pull request may close this issue.

3 participants