Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make font types in search and filters modal consistent #1815

Closed
11 tasks done
ryanfchase opened this issue Sep 7, 2024 · 7 comments · Fixed by #1821
Closed
11 tasks done

Make font types in search and filters modal consistent #1815

ryanfchase opened this issue Sep 7, 2024 · 7 comments · Fixed by #1821
Assignees
Labels
Good First Issue Good for newcomers P-feature: Search/Filter Modal Role: Frontend React front end work size: 0.25pt Can be done in 1.5 hours

Comments

@ryanfchase
Copy link
Member

ryanfchase commented Sep 7, 2024

Overview

We need to make fonts on the search and filters modal consistent so users don't get confused about how the modal works

Action Items

  • Grab the color, font size, and font weight for "Request Types" in the Search and Filters Modal

    • loc: /components/main/Desktop/TypeSelector/index.js , line: 22, 83
  • Apply that color, font size, and font weight to "Boundaries"

    • loc: /components/main/Desktop/CouncilSelector/index.js
    • 1. Add class style from collapsible section - ADD: Header class style for "Boudaries"
    • 2. Update class classes.label to classes.header for "Boundaries" title
    • 3. Cleanup, Delete class style from collapsible section - DELETE: Label class style for "Boundaries"
  • Apply that color, font size, and font weight to "Date Range"

    • loc: componenets/DataSelector/DataSelector.jsx
    • 1. Add useStyle & class style from collapsible section - ADD: useStyle const for "Date Range"
    • 2. Delete import useStyle from ...
    • 3. Add import makeStyles from '@mui/styles/makeStyles';
    • 4. Update span to div for the title value Date Range 
    • 5. Update className={label} to className={classes.header}

Collapsible Sections

ADD: Header class style for "Boudaries"
  header: {
    fontSize: '12.47px',
    fontWeight: theme.typography.fontWeightMedium,
    marginBottom: '8px',
  },
DELETE: Label class style for "Boundaries"
  label: {
    display: 'inline-block',
    font: theme.typography.b2,
    marginBottom: '10px',
    color: theme.palette.secondary.light,
  },
ADD: useStyle const for "Date Range"
const useStyles = makeStyles(theme => ({
  header: {
    fontSize: '12.47px',
    fontWeight: theme.typography.fontWeightMedium,
    marginBottom: '8px',
  },
}));

Resources/Instructions

  • Figma design file link
Screenshot before proposed changes

image

Screenshot after proposed changes

![image](https://github.com/user-attachments/assets/85c9c00a-d0ca-45b7-9266-619fe71fa326)

@ryanfchase ryanfchase added Good First Issue Good for newcomers Role: Frontend React front end work size: 0.25pt Can be done in 1.5 hours P-feature: Search/Filter Modal labels Sep 7, 2024
@ryanfchase ryanfchase added the ready for dev lead ready for developer lead to review the issue label Sep 7, 2024
@ryanfchase
Copy link
Member Author

Ready for dev lead. I think it's a "Good First Issue". Happy to add more in-depth instruction if required.

@traycn
Copy link
Member

traycn commented Sep 7, 2024

Reviewing as dev lead:
ETA - 9/8
Time - 12pm PT

@traycn
Copy link
Member

traycn commented Sep 8, 2024

Updated Action Items with file loc, line, and implementation for "Boundaries" and "Date Range" titles in the search/filter map modal.

Comment on my findings:

Style implementation for each title is inconsistent across the 3 Titles in the modal. To introduce consistency, I've proposed a solution to use the useStyle for each file to be consistent with how the style title "Request Types" is implemented.

IMPORTANT NOTE:

Use style has been deprecated since 2021 and is now Legacy. It is not recommended for use.
Link to useStyle docs here.

Issue created to address deprecated @mui/style - #1820

@traycn traycn added ready for prioritization and removed ready for dev lead ready for developer lead to review the issue labels Sep 8, 2024
@traycn
Copy link
Member

traycn commented Sep 8, 2024

Updated the description a second-time. Issue previously did not update with the detailed action items points.

@ryanfchase
Copy link
Member Author

This ticket has been prioritized and is ready to be picked up 👍

@Brandoncyu Brandoncyu self-assigned this Sep 9, 2024
@Brandoncyu
Copy link
Member

Brandoncyu commented Sep 9, 2024

Updates have been made:
image

@Brandoncyu
Copy link
Member

PR has been made: #1821

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good for newcomers P-feature: Search/Filter Modal Role: Frontend React front end work size: 0.25pt Can be done in 1.5 hours
Projects
Status: Done (without merge)
Development

Successfully merging a pull request may close this issue.

3 participants