Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request type legend - map - collapsible (desktop/mobile) #834

Closed
1 of 8 tasks
adamkendis opened this issue Nov 3, 2020 · 9 comments
Closed
1 of 8 tasks

Request type legend - map - collapsible (desktop/mobile) #834

adamkendis opened this issue Nov 3, 2020 · 9 comments
Labels
P-feature: Desktop desktop-specific development task P-feature: Mobile work done to make the site mobile accessible Role: Frontend React front end work Size: 3pt Can be done in 13-18 hours to update!

Comments

@adamkendis
Copy link
Member

adamkendis commented Nov 3, 2020

Description

A collapsible map legend displaying request type names and colors.

Action Items

Standard stuff:

  • Functional component using React Hooks strongly encouraged.
  • Styling via one of material-ui's styling options.

Component stuff:

  1. Implement button to show map legend. Use material-ui.

    • Must be able to tab to the button. (desktop)
    • When button is focused, activate via mouseclick, space or enter keypresses. (desktop)
    • Tap to activate (mobile).
  2. Implement legend.

    • When open, the close/X button should be tabbable. (desktop)
    • Close/X button activated via mouseclick, space or enter keypresses. (desktop)
    • Close/X button activated via tap (mobile)
    • Individual items within the legend should not be tabbable (probably - discuss if you think otherwise)
    • Do not hardcode the request types/colors into the component jsx. We will ultimately fetch the request types/colors from the backend. Basically, this component should receive and render the list via props. Okay to create a list of request types/colors for frontend use until backend is ready.

Resources

https://material-ui.com/styles/advanced/#makestyles

Collapsed:
Screen Shot 2020-11-19 at 5 26 06 PM

Expanded:
Screen Shot 2020-11-19 at 5 26 44 PM

@adamkendis adamkendis added Role: Frontend React front end work Needs More Info Request for more info...Issue not clear labels Nov 3, 2020
@adamkendis adamkendis added P-feature: Mobile work done to make the site mobile accessible P-feature: Desktop desktop-specific development task and removed Needs More Info Request for more info...Issue not clear labels Nov 20, 2020
@tan-nate tan-nate self-assigned this Jan 21, 2021
@tan-nate
Copy link
Contributor

Still working on this, took a little while than I thought wrapping my head around Material UI. Got the expanded legend done and now just working on the collapsible feature.

@adamkendis adamkendis added this to the Initial v2 Launch milestone Feb 12, 2021
@adamkendis adamkendis added the Size: 2pt Can be done in 7-12 hours label Feb 12, 2021
@adamkendis
Copy link
Member Author

Moving ticket to prioritized backlog. In progress branch https://github.com/hackforla/311-data/tree/834-collapsible-legend

@adamkendis adamkendis added Size: 3pt Can be done in 13-18 hours and removed Size: 2pt Can be done in 7-12 hours labels Apr 1, 2021
@github-actions
Copy link

github-actions bot commented Jul 1, 2021

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in X days.

@github-actions github-actions bot added the Stale label Jul 1, 2021
@KristenDLR KristenDLR self-assigned this Aug 13, 2021
@captain-nimo
Copy link
Member

Please provide update:

  1. Progress
  2. Blocks
  3. Availability
  4. ETA

@github-actions github-actions bot removed the Stale label Aug 20, 2021
@KristenDLR
Copy link

Progress: In progress, material-ui button to show map legend.
Blocks: Need some guidance on functionality, will discuss a scheduled meeting for this upcoming week.
Availability: Wednesday anytime after 2pm, Friday anytime after 2pm

@KristenDLR
Copy link

Progress: Component constructed and finishing styling with makeStyles/themes

Blocks:

  • When open, the close/X button should be tabbable. (desktop)
  • Close/X button is activated via mouseclick, space or enter keypresses. (desktop)
  • Close/X button activated via tap (mobile)

Availability: Monday anytime before 8pm, or Wednesay anytime.

@KristenDLR
Copy link

Progress: Issued pull request, collapsable legend. After the meeting and PR received suggested changes. Will be working on it this week, for next week's review.

@ExperimentsInHonesty
Copy link
Member

@KristenDLR Please provide update

  1. Progress
  2. Blockers
  3. Availability
  4. ETA

@ExperimentsInHonesty
Copy link
Member

@KristenDLR Please provide update
Progress
Blockers
Availability
ETA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-feature: Desktop desktop-specific development task P-feature: Mobile work done to make the site mobile accessible Role: Frontend React front end work Size: 3pt Can be done in 13-18 hours to update!
Projects
Status: Done (without merge)
Development

Successfully merging a pull request may close this issue.

7 participants