Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: GPS / Use My Location button is disabled on map #1101

Closed
1 task
Tracked by #1098
fancyham opened this issue Nov 19, 2021 · 5 comments · Fixed by #1133
Closed
1 task
Tracked by #1098

Bug: GPS / Use My Location button is disabled on map #1101

fancyham opened this issue Nov 19, 2021 · 5 comments · Fixed by #1133
Labels
Missing: Milestone This issue is not part of any milestone P-Feature: Map Food seeker map view PM: Food Seekers Release Note: Bug Something isn't working (Shows on release notes under "Bug Fixes") Role: Front-end Front End Developer size: 1pt The lift to complete this user story 1-2hrs

Comments

@fancyham
Copy link
Collaborator

fancyham commented Nov 19, 2021

Overview

In the past few days, the ‘crosshairs’ button to get the user’s location via GPS has been disabled both on web and mobile when in map mode.

Note the “Use my current location” button on landing page does work properly.

Perhaps this is a regression due to a recent update?

How to replicate

  1. Go to foodoasis.la
  2. Tap magnifying glass to show all of LA
  3. Notice that crosshairs button in upper right corner is greyed out:

image

Platforms and apps

Safari desktop
Safari mobile

Action Items

  • Reactivate ‘get my location’ button

Resources/Examples

@fancyham fancyham added Role: Front-end Front End Developer P-Feature: Map Food seeker map view Missing: Size The effort estimate for this issue is missing Release Note: Bug Something isn't working (Shows on release notes under "Bug Fixes") labels Nov 19, 2021
@Benbaillou Benbaillou added the Missing: Milestone This issue is not part of any milestone label Dec 7, 2021
@Benbaillou Benbaillou added size: 1pt The lift to complete this user story 1-2hrs and removed Missing: Size The effort estimate for this issue is missing labels Jan 25, 2022
@entrotech
Copy link
Member

This is now implemented as follows:
If the user has not enabled location for the site in their browser, the "GPS" (aka re-center) button will be disabled.
If the user has enabled location for the site in their browser, then when the re-center button is pressed, the map will be re-centered on the user's location, and the "start" pin, if any, will be moved to the user's location as well.

@fancyham
Copy link
Collaborator Author

fancyham commented Mar 25, 2022

Oops

@fancyham
Copy link
Collaborator Author

fancyham commented Mar 25, 2022

Looks good — one bug I came across:

It seems like if I deny access to my location when first loading the site, the site still thinks that I have denied it permanently and the GPS button doesn’t work? The button looks clickable (blue background) but it doesn’t seem to do anything.

To recreate:

  1. Mac Safari (Monterey, latest version of Safari)
  2. Click ‘Use my current location’, but do NOT select ‘remember for a day"
  3. When Safari asks, deny access to location
  4. Type in ‘LA’ and get map
  5. GPS button looks active. Click it.
  6. Nothing happens. Expectation was that the website would request my location again and I would see a Safari location request dialog again because the button looked active.

If the button is non-functional, we should make it look disabled.

I’d lean towards trying to get the location whenever the user requests it and showing a message or disabling the button when that request is rejected… and not store that state in the user session.

I’d ideally like to be able to change my browser’s location sharing preferences to grant access to the location, return to the website, reload the page if necessary, and get my location using that button.

@sei1122
Copy link
Member

sei1122 commented Mar 25, 2022

I enabled location settings for Chrom browser and pressed the Re-center button, it is working :)
Location pin is pointed where I live and center on the map.

@ryu-jieun
Copy link
Member

It's working on my safari (iphone 11).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Missing: Milestone This issue is not part of any milestone P-Feature: Map Food seeker map view PM: Food Seekers Release Note: Bug Something isn't working (Shows on release notes under "Bug Fixes") Role: Front-end Front End Developer size: 1pt The lift to complete this user story 1-2hrs
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants