Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Deep linking on the Map Page is broken #989

Closed
1 task done
entrotech opened this issue May 19, 2021 · 4 comments · Fixed by #1133
Closed
1 task done

Bug: Deep linking on the Map Page is broken #989

entrotech opened this issue May 19, 2021 · 4 comments · Fixed by #1133
Labels
Missing: Milestone This issue is not part of any milestone P-Feature: Map Food seeker map view PM: Food Seekers Release Note: Bug Something isn't working (Shows on release notes under "Bug Fixes") Role: Front-end Front End Developer size: 3pt The lift to complete this user story 4-8hrs

Comments

@entrotech
Copy link
Member

entrotech commented May 19, 2021

Overview

When an organization is selected by clicking on a map pin or selecting it from the results list, the URL changes to indicate the selected organization, e.g. https://foodoasis.la/organizations?org=blood_of_jesus_prayer_and_deliverance_ministry The intent is that a user could copy that url and sned it to someone else, who could then past the url into the browser and display that organization in the app. However, this does not work now, because the original implementation only partially worked and the code to navigage to the specific organization is commented out.

Launch note: the final deep link is something like this: https://foodoasis.la/organizations?latitude=34.0470527045858&longitude=-118.241670138212&org=little_tokyo_towers&id=4877

latitude and longitude center the map and do a search
If displaying details for a single org, then id is required.
The org parameter key seems to be optional for now, but is useful for URL readability.

Action Items

  • To do this right, the SearchResults component may need to run an initial query to locate the specific organization by name, set the center of the map to that organization and then run the query for the area displayed on the map. It's probably not necessary to set the same zoom level as the original page.

Resources/Instructions

@entrotech entrotech added the size: 3pt The lift to complete this user story 4-8hrs label May 19, 2021
@entrotech entrotech changed the title Bug: Deep linking is broken Bug: Deep linking on the Map Page is broken May 19, 2021
@gigicobos gigicobos added the P-Feature: Map Food seeker map view label Jul 22, 2021
@sameergautam sameergautam added Missing: Role The role is missing from this issue Role: Front-end Front End Developer and removed Missing: Role The role is missing from this issue labels Jul 28, 2021
@fancyham fancyham added the Release Note: Bug Something isn't working (Shows on release notes under "Bug Fixes") label Aug 13, 2021
@entrotech entrotech assigned hanapotski and unassigned entrotech Nov 19, 2021
@Benbaillou Benbaillou added the Missing: Milestone This issue is not part of any milestone label Dec 7, 2021
@fancyham
Copy link
Collaborator

I tried a bunch and it seems okay to me — didn’t do exhaustive testing though

@sei1122
Copy link
Member

sei1122 commented Mar 25, 2022

looks good.

@ryu-jieun
Copy link
Member

Looks good

@fancyham
Copy link
Collaborator

Yes - it works! The URL given in the issue description won't work but the new deep link URL does seem to work.

The final deep link URL is something like this:
https://foodoasis.la/organizations?latitude=34.0470527045858&longitude=-118.241670138212&org=little_tokyo_towers&id=4877

Someday, it would be nice to specify an org name query in the URL, but I believe that currently, the most important piece of the URL is the lat/long and id. The 'org' parameter seems to be optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Missing: Milestone This issue is not part of any milestone P-Feature: Map Food seeker map view PM: Food Seekers Release Note: Bug Something isn't working (Shows on release notes under "Bug Fixes") Role: Front-end Front End Developer size: 3pt The lift to complete this user story 4-8hrs
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

9 participants