Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Current VRMS Slackbot Implementation #16

Closed
2 of 3 tasks
Neecolaa opened this issue Feb 24, 2022 · 1 comment
Closed
2 of 3 tasks

Review Current VRMS Slackbot Implementation #16

Neecolaa opened this issue Feb 24, 2022 · 1 comment
Labels
feature: slackbot role: Site Reliability Engineer aka Infrastructure Engineer size: 1pt Can be done in 4-6 hours

Comments

@Neecolaa
Copy link
Member

Neecolaa commented Feb 24, 2022

Overview

We need to do a deep dive on the existing VRMS slackbot.

Action Items

  • Create a list of files changed during slackbot PRs (add to Resources/Instructions)
  • Look through current code to figure out what it's doing
  • Contact VRMS team for information

Resources/Instructions

Closed pull requests related to slackbot: https://github.com/hackforla/VRMS/pulls?q=is%3Apr+slackbot+is%3Aclosed+

@fyliu
Copy link
Member

fyliu commented Jun 13, 2022

Looks like I should have commented on this issue rather than the other one. See that issue for reference.

The quick summary

  1. I went to some VRMS meetings and learned that they are no longer using their old slackbot that this issue is interested in.
  2. The person who wrote it is also no longer with the project.
  3. I did review the current code and it's not being called anymore. What it did was use the bot to send messages to slack users using their IDs. It's not actually using the slack app, but was calling the slack API from software.
  4. During a later VRMS meeting, there was someone, Tim Shaker, who was working on a new slack app. It sounded like what we're trying to do in OPS. But if they're doing it in VRMS, there's no point in OPS finding out the implementation and working on another one, since there's only 1 remaining app slot in the free slack tier.

I think we should close this issue. It's no longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: slackbot role: Site Reliability Engineer aka Infrastructure Engineer size: 1pt Can be done in 4-6 hours
Projects
Development

No branches or pull requests

4 participants