Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Table: user (replace role association with practice area) #172

Open
9 of 16 tasks
Neecolaa opened this issue Jul 14, 2023 · 5 comments
Open
9 of 16 tasks

Update Table: user (replace role association with practice area) #172

Neecolaa opened this issue Jul 14, 2023 · 5 comments
Labels
complexity: missing feature: update table p-feature: user PII: TRUE Table or function has or uses Personally Identifiable Information (PII) ready for db architect role: back end s: CTJ stakeholder: Civic Tech Jobs s: kb stakeholder: knowledgebase s: VRMS stakeholder: VRMS size: 1pt Can be done in 4-6 hours

Comments

@Neecolaa
Copy link
Member

Neecolaa commented Jul 14, 2023

Overview

We need to update the user table model to utilize the practice area table instead of the outdated role table.

Details

The initial model issue is #15

Discussion leading to this change is here: #170

Action Items

  • Update schema information
  • Update existing Django model
  • Write a test for the new relationships this model will have with other models (e.g., creating a user and assigning them a set of permissions on a project) if any.
  • Update API end point
  • Update API unit tests
  • Document the endpoint in Swagger

Changes Needed

Columns to Remove

  • desired_roles - varchar
  • practice_area_current - int (practice_area_id)

Columns to Add

  • practice_area_primary - FK int (practice_area_id)
  • practice_areas_secondary - FK int (practice_area_id)

Additional Changes

  • Remove relationship between user and role tables (table spreadsheet & ERD)
  • Add relationship between user and practice_area (table spreadsheet & ERD)

Resources

@Neecolaa Neecolaa added role: back end size: 1pt Can be done in 4-6 hours p-feature: user s: CTJ stakeholder: Civic Tech Jobs s: VRMS stakeholder: VRMS s: kb stakeholder: knowledgebase PII: TRUE Table or function has or uses Personally Identifiable Information (PII) feature: ERD/SS adjustment Requires adjustments to be made to the ERD & Spreadsheet feature: update table labels Jul 14, 2023
@Neecolaa Neecolaa added this to the v0.01 - initial setup milestone Jul 14, 2023
@fyliu
Copy link
Member

fyliu commented Aug 11, 2023

This looks ready to be worked on to me.

@fyliu fyliu changed the title Update Table: user Update Table: User to replace role association with practice area Dec 21, 2023
@Neecolaa Neecolaa changed the title Update Table: User to replace role association with practice area Update Table: user (replace role association with practice area) Jan 14, 2024
@Neecolaa Neecolaa removed the feature: ERD/SS adjustment Requires adjustments to be made to the ERD & Spreadsheet label Jan 14, 2024
@drakeredwind01
Copy link
Member

drakeredwind01 commented May 24, 2024

@Neecolaa

  • Columns to Add
    • practice_area_primary - int (practice_area_id) # add to which model
    • practice_areas_secondary - int[] (practice_area_id) # add to which model

Nicole will decide if we are keeping this in this issue or adding it to a join table

@Neecolaa
Copy link
Member Author

Neecolaa commented Jun 7, 2024

We're going to add a join table. Issues will be created to add the new table to the schema. This issue is fine otherwise

@shmonks

This comment was marked as resolved.

@drakeredwind01

This comment was marked as resolved.

@shmonks shmonks moved this from ❓Questions/Review to 🆕New Issue Review in P: PD: Project Board Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: missing feature: update table p-feature: user PII: TRUE Table or function has or uses Personally Identifiable Information (PII) ready for db architect role: back end s: CTJ stakeholder: Civic Tech Jobs s: kb stakeholder: knowledgebase s: VRMS stakeholder: VRMS size: 1pt Can be done in 4-6 hours
Projects
Status: 🆕New Issue Review
Development

No branches or pull requests

6 participants