Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Table: organization (formerly brigade) #56

Open
5 of 14 tasks
ericvennemeyer opened this issue Sep 9, 2022 · 4 comments
Open
5 of 14 tasks

Create Table: organization (formerly brigade) #56

ericvennemeyer opened this issue Sep 9, 2022 · 4 comments
Labels
complexity: missing feature: ERD/SS adjustment Requires adjustments to be made to the ERD & Spreadsheet feature: table creation p-feature: multi-tenant features that will only sbe used after MVP when we are ready to make avail externally PII: FALSE Table or function does not have or use Personally Identifiable Information (PII) question Further information is requested ready for db architect role: db architect s: kb stakeholder: knowledgebase s: org stakeholder: the org (includes stats) s: PD team stakeholder: People Depot Team s: VRMS stakeholder: VRMS size: 2pt Can be done in 7-12 hours

Comments

@ericvennemeyer
Copy link
Member

ericvennemeyer commented Sep 9, 2022

Overview

We need to create the organization table so that we can update a shared data store across hackforla.org, vrms, civictechjobs, and tables (onboarding) project.

Details

A table and a model are the same thing

Action Items

  • identify and document table description (see spreadsheet under Resources)
    • if not, reach out to PD leads
  • compare and check off the data fields (below) against the ERD. Note any fields in the ERD that's missing from the list. (see Resources)
  • compare the check off associated tables (below) against the ERD. Note any associated tables in the ERD that's missing from the list (see Resources)
  • create a single model in Django (defining schema)
  • write a test for the relationships this model will have with other models (e.g., creating a user and assigning them a set of permissions on a project).
  • write an API end point
  • write API unit tests
  • document the endpoint

Resources/Instructions

Description

List of organizations (formerly brigades)

Data Fields

  1. Copied from spreadsheet and checked off according to ERD. (unchecked items indicate a mismatch between ERD and spreadsheet, which requires a review)

    • (PK) id - int - Record Id
    • name - varchar()
    • time_zone - varchar()
  2. In ERD only (having items here indicates a mismatch, which requires a review)

    • None

Associated Tables

  1. Copied from spreadsheet and checked off according to ERD. (unchecked items indicate a mismatch between ERD and spreadsheet, which requires a review)

  2. In ERD only (having items here indicates a mismatch, which requires a review)

    • None
@fyliu fyliu mentioned this issue Sep 11, 2022
39 tasks
@fyliu fyliu added this to the All tables added milestone Sep 25, 2022
@ExperimentsInHonesty ExperimentsInHonesty added p-feature: multi-tenant features that will only sbe used after MVP when we are ready to make avail externally s: VRMS stakeholder: VRMS s: PD team stakeholder: People Depot Team s: org stakeholder: the org (includes stats) labels Mar 5, 2023
@ExperimentsInHonesty ExperimentsInHonesty added the PII: FALSE Table or function does not have or use Personally Identifiable Information (PII) label May 4, 2023
@ExperimentsInHonesty ExperimentsInHonesty added the s: kb stakeholder: knowledgebase label Dec 6, 2023
@Neecolaa Neecolaa added the feature: ERD/SS adjustment Requires adjustments to be made to the ERD & Spreadsheet label Jan 12, 2024
@Neecolaa
Copy link
Member

Neecolaa commented Jan 12, 2024

This table will be renamed to organization

Updates needed:

  • Update Issues
    • this issue
    • connected issues
      • recurring_event
      • user_check
  • Update ERD
    • name
    • connected fields
  • Update Spreadsheet
    • table tab
      • name
      • connections
    • fields tab
      • name
      • connected fields (brigade_id changed to org_id)

After updates

  • remove erd/ss label
  • return to prioritized backlog
  • hide this comment

@Neecolaa Neecolaa changed the title Create Table: brigade Create Table: organization (formerly brigade) Mar 1, 2024
@Neecolaa
Copy link
Member

Neecolaa commented Mar 1, 2024

Questions:

  • Do we want to create a new issue for updating the event table? Or should we wait until we know what we're doing with Epic: Redesign event schema #88
  • Are we renaming the permission type adminBrigade (to adminOrg or something similar)?

@Neecolaa Neecolaa added the question Further information is requested label Mar 1, 2024
@fyliu
Copy link
Member

fyliu commented Mar 22, 2024

We talked about the first one at the meeting but I want to comment so it's recorded.
We don't need to wait for the event schema redesign. Event will still reference organization in the same way. So it's fine to create an issue now to update the event table.

The other thing we talked about was whether we want to create the relationship between organization and affiliate, whether it's a sponsor and/or partner. Currently, there's no relationship and the affiliate object just has the fields is_org_partner and is_org_sponsor in it.

@ExperimentsInHonesty
Copy link
Member

@Neecolaa do you feel you have enough answers in order to finish this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: missing feature: ERD/SS adjustment Requires adjustments to be made to the ERD & Spreadsheet feature: table creation p-feature: multi-tenant features that will only sbe used after MVP when we are ready to make avail externally PII: FALSE Table or function does not have or use Personally Identifiable Information (PII) question Further information is requested ready for db architect role: db architect s: kb stakeholder: knowledgebase s: org stakeholder: the org (includes stats) s: PD team stakeholder: People Depot Team s: VRMS stakeholder: VRMS size: 2pt Can be done in 7-12 hours
Projects
Status: ❓Questions/Review
Development

No branches or pull requests

4 participants