Implement Filtering by Name, Address, Alt #, Building Permit, Created By from Column Headers on My Project Page

[entrotech]

Overview

• Implement the Name, Address, Alt #, Building Permit, Created By Filters on the My Projects Page per the Figma Prototype references in the Resources paragraph below to comply with the filter re-design of Issue Design Mockup: Redesign the My Projects Filtering UI #1578.

Action Items

• This is partially implemented by Issue Implement Code Infrastructure for new My Projects Sorting and Filtering #1801. Please read that issue first for background information, adjustments John Darragh made to the design of all the filter pop-ups for consistency with our style guide, and information about what is done so far.
• For this issue, you will need to complete the component implementation. You will probably need to modify one or more parent components to pass an additional prop that references the entire collection of projects, so you can extract the list of matches for the "auto-complete" component the design calls for.
• Use the component implementation in the same directory as an example.
• remove the dependency from Modify the behavior of the Search By Text Box on the My Projects page #1649 and move it to new issue approval column.

Resources/Instructions

Refer to this Figma prototype: https://www.figma.com/proto/nD9QK56Mzq7xNSaSUoeGx0/TDM-Calculator?type=design&node-id=12173-2052&t=wQuxLI1JbOw0OzLn-1&scaling=scale-down&page-id=2499%3A11472&starting-point-node-id=11997%3A885

[roslynwythe]

1. Progress:

   • Filtering on Name, Address, Alt # and Created By columns is functional. See screenshot below

2. Blockers:

   • I don't see Building Permit column so I'm not sure how to implement that filter
   • pre-commit hook is failing:

> git -c user.useConfigOnly=true commit --quiet --allow-empty-message --file -
.husky/pre-commit: line 4: lerna: command not found
husky - pre-commit hook exited with code 127 (error)
husky - command not found in PATH=/mingw64/libexec/git-core:/mingw64/bin:/usr/bin:/c/Users/rosly/bin:/c/Program Files/Volta:/cmd:/c/Python312/Scripts:/c/Python312:/c/Program Files/Common Files/Oracle/Java/javapath:/c/Python311/Scripts:/c/Python311:/c/WINDOWS/system32:/c/WINDOWS:/c/WINDOWS/System32/Wbem:/c/WINDOWS/System32/WindowsPowerShell/v1.0:/c/WINDOWS/System32/OpenSSH:/c/Program Files/dotnet:/c/Program Files/Docker/Docker/resources/bin:/c/ProgramData/chocolatey/bin:/c/Program Files/nodejs:/c/Users/rosly/AppData/Roaming/npm:/c/Users/rosly/AppData/Local/Volta/bin:/c/Users/rosly/AppData/Local/Microsoft/WindowsApps:/c/Users/rosly/AppData/Local/Programs/Microsoft VS Code/bin:/c/Users/rosly/AppData/Roaming/npm

3 Availability: 12 hours/week
4. ETA: 9/9
5. Screenshot of sample filter UI:

[entrotech]

Yes, the building permit column is gone, so we don't need that.

Others have encountered the problem with the pre-commit hook as well. It's a problem with an npm package called lerna, which allows you to run commands on multiple projects in a monorepo with a single command - in this case the pre-commit hook tries to run lint on the client and server projects. The pre-commit hook tries to run the lerna command from the command line and is failing. Here's something to try: Open a terminal window and set the directory to the root folder of the project. Then run
npm install -g lerna
from the terminal to install lerna globally on your machine.
Let me know it this works - if it does, I'll add it to the Contributing Code page of the wiki.

If the commit still doesn't work, you can work-around it by committing with the --no-verify option to bypass the pre-commit hook:
git commit --no-verify -m "<your commit message>"

(But then we still need to figure out what needs to be done to get the hook to work.)

Also, you will probably find that the ,/push.sh script won't work, since there are some failing unit tests that need to get fixed, so you will need to use the alternative
git push origin HEAD

I look forward to checking out your PR ;-)

[roslynwythe]

Thank you @entrotech - running the command you suggested npm install -g lerna resolved the pre-commit problem. Earlier in the day, I suspected that the dependencies should be installed globally so I had tried npm install -g but that did not work.

• PR Implement filtering on Name, Address, Alt# and Created By column headings #1828

[ExperimentsInHonesty]

Notes from 2024-09-17 stakeholder meeting: Keep search inside column, and only show what is in the results. If results are filtered, it will only show those. Change from “Search” to “Filter”

[entrotech]

@ExperimentsInHonesty I don't understand your above comments. Are you talking about the list option or the drop-down option, or something else? How is this different than what is implemented in dev? Maybe the comments on the slide deck are outdated?
cc @roslynwythe