Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create mobile version of the Guide Pages and ensure responsiveness #1515

Open
5 of 10 tasks
abenipa3 opened this issue May 5, 2021 · 33 comments
Open
5 of 10 tasks

Create mobile version of the Guide Pages and ensure responsiveness #1515

abenipa3 opened this issue May 5, 2021 · 33 comments
Labels
Complexity: Large Dependency An issue is blocking the completion or starting of another issue p-Feature: Mobile P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: front end Tasks for front end developers size: 8pt Can be done in 31-48 hours

Comments

@abenipa3
Copy link
Member

abenipa3 commented May 5, 2021

Dependency

Overview

We learned that Jekyll is a feasible option because it can render Markdown files into HTML as seen in #1085.

Now we need to create a mobile version of it and ensure that the codes are responsive on all screens.

Action Items

  • Create a mobile version in the prototype.
  • Design mobile version of guide pages.
  • Consult with the product and design team.

Future Items

  • Implement prototype into the HfLA repository. (The prototype is currently in @alyssabenipayo for testing purposes.)
  • Create documentation of how the Jekyll Guide Pages works and how the team can use it.
  • Add it HfLA's Drive. Get approval from the team.

Resources/Instructions

Guide Pages Figma File
HfLA Guide Pages Design Issue
Alyssa's Repository for the Guide Pages Prototype

@abenipa3 abenipa3 added role: front end Tasks for front end developers Complexity: Large labels May 5, 2021
@abenipa3 abenipa3 self-assigned this May 5, 2021
@abenipa3
Copy link
Member Author

abenipa3 commented May 8, 2021

Progress: Just assigned this issue to myself.
Blocks: N/A
Availability: Will be available starting on 5/13 to work on this issue.
ETA: I might have some progress on 5/15.

@abenipa3 abenipa3 added the To Update ! No update has been provided label May 8, 2021
@qiqicodes qiqicodes added Status: Updated No blockers and update is ready for review and removed To Update ! No update has been provided labels May 9, 2021
@abenipa3 abenipa3 added To Update ! No update has been provided Status: Updated No blockers and update is ready for review and removed Status: Updated No blockers and update is ready for review To Update ! No update has been provided labels May 9, 2021
@qiqicodes
Copy link
Member

@alyssabenipayo Can you let us know your progress in regards to this issue? Thank you =]

Progress:
Blockers:

@qiqicodes qiqicodes added To Update ! No update has been provided and removed Status: Updated No blockers and update is ready for review labels May 15, 2021
@abenipa3
Copy link
Member Author

abenipa3 commented May 15, 2021

Progress: Planning to work on it today (5/15). Will update this post before our Sunday meeting. Started working on creating the mobile version with CSS. Experimenting between hiding the navbar and creating an accordion.

Screenshot for mobile version without navbar

image

Blocks: Have been focusing on Hackathon this past week. Learned a lot from the experience (especially with CSS and a bit of JavaScript) that I’m excited to continue with this issue.

Availability: Open this coming week. (Yay!)

ETA: 5/22.

@abenipa3 abenipa3 added Status: Updated No blockers and update is ready for review and removed To Update ! No update has been provided labels May 16, 2021
@abenipa3
Copy link
Member Author

abenipa3 commented May 21, 2021

Progress:

  • Created wireframes for the mobile designs as mentioned in Design HfLA Guide Pages #1525.
  • Applied the media query works in the prototype to hide nav-bar in all mobile devices as seen below. Repo here.

githubissue

Blocks: N/A

Availability: Open!

ETA: 5/23/21

@abenipa3
Copy link
Member Author

abenipa3 commented May 26, 2021

Progress:

  • Reviewed wireframes with Design and Product as stated in Design HfLA Guide Pages #1525
  • Next Objective:
    • Add code with a collapsible menu to the prototype.

Block: N/A
Availability: Open
ETA: 5/29/21

@abenipa3
Copy link
Member Author

abenipa3 commented May 26, 2021

Feedback from Dev Team: We learned that the most feasible way to develop is to hide the nav-bar.

Will have the prototype ready by Sunday.

@abenipa3
Copy link
Member Author

abenipa3 commented May 30, 2021

Progress:

Added page-card and media query to hide the nav-bar as seen below.

Screen capture for page-card update

image

Screen capture for Media Query Update

prototype-guide-page

Block: N/A

Availability: Open

ETA: Ready for review.

@abenipa3 abenipa3 mentioned this issue May 30, 2021
2 tasks
@abenipa3
Copy link
Member Author

abenipa3 commented May 30, 2021

Feedback from Sunday Meeting: We would like to update the mobile prototype where the table of contents is hiding at the top (hamburger menu) while a top scroll button appears after the user scrolls through the page.

Note for future references (potential new issue): Create an accordion for mobile.

@abenipa3 abenipa3 added To Update ! No update has been provided and removed Status: Updated No blockers and update is ready for review labels May 30, 2021
@abenipa3
Copy link
Member Author

abenipa3 commented Jun 6, 2021

Progress: Added scroll to top button for mobile.

Screen capture

scrolltop

Block: Will review new wireframes with design team.

Availability: Open

ETA: TBD

@abenipa3 abenipa3 added Status: Updated No blockers and update is ready for review and removed To Update ! No update has been provided labels Jun 9, 2021
@abenipa3
Copy link
Member Author

abenipa3 commented Jun 13, 2021

Progress: Scroll to top button bug fixed! Also added links to the page card, which will only appear on mobile.

scrolltopandlinks

Would like feedback on the links on page card as seen in the GIF above.
Had to create a div in markdown file for it to work. Any suggestions?
image

Block: None.

Availability: Open

ETA: 6/13/21

@abenipa3
Copy link
Member Author

Feedback from 6/13 Meeting:

  • We want to avoid having to add HTML in the markdown so Akib suggested toc.
    • Will revisit the toc prototype to test it!
  • ETA: Latest 6/19. Earliest 6/15.

@abenipa3
Copy link
Member Author

abenipa3 commented Aug 1, 2021

Just found out how it really looks like on mobile.

Current Mobile Preview

image

I manually coded the parallelogram. I think a quick solution to this is downloading the svg of the hero image with the shape from our Figma and implement it on our prototype. With that, we would avoid visual issues in the future.

Going to reach out to Design and Dev teams for feedback and update again today.

Updated ETA: 8/1/21

References:

Original Image without Parallelogram

Mask Group

Original Image with Parallelogram

Getting-the-most

UPDATE (8/5/21): Design and Dev teams said that downloading the svg image with the parallelogram is a workable solution. Will proceed to have this issue reviewed with Product.

@abenipa3
Copy link
Member Author

abenipa3 commented Aug 5, 2021

@Sihemgourou @ExperimentsInHonesty Hello! Guide Pages Prototype is ready to review. I've consulted with our dev and design teams to see if they have feedback, and they said it looks good so far.

Please see the link for the prototype below and feel free to let me know if you have any questions! Thanks.

https://alyssabenipayo.github.io/guidepages-prototype/

@Sihemgourou Sihemgourou added this to the 11. Frameworks milestone Aug 9, 2021
@Sihemgourou
Copy link
Contributor

Great @alyssabenipayo ! could you put it in the review column please :)

@abenipa3
Copy link
Member Author

abenipa3 commented Aug 15, 2021

Update from 8/15/2021's Meeting:

  • Make the sample issues into actual issues. (We want to be able to tell that it works when it's a real issue.)
  • Add submenus to the 2FA's FAQ.
  • Update the page cards so that there's padding. Refer to HfLA's About Section as a reference.
  • Replicate the full guide of How to Make a Guide.
  • Continue working on Markdown converter for guides (10).

Blockers: None.

Availability: 8-10 hours

ETA: 8/21/21

Preview: https://alyssabenipayo.github.io/guidepages-prototype/

@abenipa3
Copy link
Member Author

abenipa3 commented Aug 18, 2021

Additional Notes from Previous Update:

  • Check the headings for each section title.
  • Styling not applied to subsections of the navbar in mobile and tablet. Need to update.
  • Edit the indentation of the subsections (See JavaScript).

@abenipa3
Copy link
Member Author

Update 8/20/21

Will be redesigning the Guide Pages as mention in #1630. Status of this issue: TBD

@github-actions github-actions bot removed the Status: Updated No blockers and update is ready for review label Aug 27, 2021
@github-actions
Copy link

@alyssabenipayo

Please add update using this template (even if you have a pull request)

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, August 24, 2021 at 12:03 AM PST.

@github-actions github-actions bot added the To Update ! No update has been provided label Aug 27, 2021
@abenipa3 abenipa3 removed their assignment Aug 27, 2021
@abenipa3 abenipa3 added Dependency An issue is blocking the completion or starting of another issue and removed To Update ! No update has been provided labels Aug 27, 2021
@abenipa3
Copy link
Member Author

abenipa3 commented Aug 27, 2021

Issue Update 8/27/21:

  • Currently redesigning the Guide Pages.
  • This issue now has a dependency in the Mobile Navigation Audit (Perform site audit of mobile navigation #2190).
  • Updated issue description with a Dependency section, added Dependency Label, and moved to the ice box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Large Dependency An issue is blocking the completion or starting of another issue p-Feature: Mobile P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: front end Tasks for front end developers size: 8pt Can be done in 31-48 hours
Projects
Development

No branches or pull requests

7 participants