Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design System: Audit Page Card CSS/HTML standard #2061

Closed
10 of 12 tasks
Tracked by #2226 ...
abuna1985 opened this issue Aug 4, 2021 · 57 comments
Closed
10 of 12 tasks
Tracked by #2226 ...

Design System: Audit Page Card CSS/HTML standard #2061

abuna1985 opened this issue Aug 4, 2021 · 57 comments
Labels
Complexity: Large Feature: Design system role: dev leads Tasks for technical leads role: front end Tasks for front end developers size: 3pt Can be done in 13-18 hours

Comments

@abuna1985
Copy link
Member

abuna1985 commented Aug 4, 2021

Overview

We need to finalize the base HTML/CSS for the .page-card and classes so we can apply the standard to all the cards within the HfLA website

Action Items

  • Find all instances of the HTML, CSS, or (inclusive) JS code for .*-card (.page-card, .small-card, .project-card, .wins-card) class.
    • Document all instances on a spreadsheet in our drive with (insert column names) (insert something about which folder in the drive)
  • Research online on what the standards are in terms of HTML tags, accessibility, etc for this component.
  • Do a write-up on your research as a comment on this issue.
    • Link this comment into your pull request. This action item was removed because a pull request is not needed, since no code changes are made.
    • Also, include this comment on the spreadsheet (merge cells might help in making this comment more visible to a viewer)
  • Edit the first item on Design System: Standardize Page Cards #2226 to include a link to the spreadsheet.
  • When ready, @ mention hackforla/website-merge in a comment to review your work and include:
    • A link to the spreadsheet you created
    • A link to the comment where you did a write-up on your research
  • Finish the audit in the spreadsheet This will be completed in new issue Design System: Recommendations for Page Card CSS/HTML Standard #4296

Merge Team

Resources/Instructions

/* Current default for page-card*/
.page-card {
    border-radius: 20px;
    overflow: hidden;
    width: 100%;
  }

Spreadsheet link: https://docs.google.com/spreadsheets/d/10-c3jpf4vtXKcwLiBC4Z3wqN777xlxbErHS4QNq-e8o/edit#gid=960681845

@abuna1985 abuna1985 added role: front end Tasks for front end developers Complexity: Medium Discussion Starting point for gathering further information and/or feedback Feature: Design system Collaborative Work Complexity: Large labels Aug 4, 2021
@abuna1985 abuna1985 changed the title Page Card Default Discuss Page Card CSS/HTML Default Aug 4, 2021
@abuna1985 abuna1985 changed the title Discuss Page Card CSS/HTML Default Finalize Page Card CSS/HTML standard Aug 11, 2021
@abuna1985 abuna1985 removed the Discussion Starting point for gathering further information and/or feedback label Aug 11, 2021
@sheltoG

This comment has been minimized.

@abuna1985

This comment has been minimized.

@ExperimentsInHonesty

This comment has been minimized.

@abuna1985

This comment has been minimized.

@abuna1985 abuna1985 reopened this Aug 24, 2021
@abuna1985 abuna1985 changed the title Finalize Page Card CSS/HTML standard Audit Page Card CSS/HTML standard Sep 5, 2021
@abuna1985 abuna1985 changed the title Audit Page Card CSS/HTML standard Design System: Audit Page Card CSS/HTML standard Sep 5, 2021
@JessicaLucindaCheng JessicaLucindaCheng added the size: 3pt Can be done in 13-18 hours label Mar 8, 2022
@Sparky-code Sparky-code self-assigned this Mar 17, 2022
@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@Sparky-code Sparky-code removed their assignment Oct 21, 2022
@hackforla hackforla deleted a comment from github-actions bot Oct 21, 2022
@hackforla hackforla deleted a comment from github-actions bot Oct 21, 2022
@hackforla hackforla deleted a comment from github-actions bot Oct 21, 2022
@hackforla hackforla deleted a comment from github-actions bot Oct 21, 2022
@hackforla hackforla deleted a comment from github-actions bot Oct 21, 2022
@Sparky-code
Copy link
Member

Note for new assignee:
This issue was expanded from the original scope to include proposed implementation by instance of each card class.
I was unable to finish this portion of the issue due to starting a new job. I think this issue should be completed as is and a new issue written to address suggestions and implementation in line with 'atomic' principles.

@JessicaLucindaCheng JessicaLucindaCheng removed the 2 weeks inactive An issue that has not been updated by an assignee for two weeks label Nov 3, 2022
@esantiano esantiano self-assigned this Jan 16, 2023
@github-actions

This comment was marked as outdated.

@esantiano

This comment was marked as outdated.

@ExperimentsInHonesty

This comment was marked as outdated.

@esantiano esantiano removed their assignment Jan 25, 2023
@ExperimentsInHonesty
Copy link
Member

@hackforla/website-merge no one will pick up this issue because they are unclear what to do. Read through it and all the assets and make a new issue that focuses on only what work remains while linking to only what they need to finish the issue.

@ExperimentsInHonesty ExperimentsInHonesty added the role: dev leads Tasks for technical leads label Mar 9, 2023
@jdingeman jdingeman added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Mar 12, 2023
@jdingeman
Copy link
Member

New issue was made here that should complete what was left of the audit:

I believe we can now close this issue. Added the new issue as a dependency for

@ExperimentsInHonesty ExperimentsInHonesty removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Large Feature: Design system role: dev leads Tasks for technical leads role: front end Tasks for front end developers size: 3pt Can be done in 13-18 hours
Projects
Development

No branches or pull requests