Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete refactor/standardization of all buttons within Home Page #2104

Closed
12 tasks done
abuna1985 opened this issue Aug 12, 2021 · 9 comments · Fixed by #3422
Closed
12 tasks done

Complete refactor/standardization of all buttons within Home Page #2104

abuna1985 opened this issue Aug 12, 2021 · 9 comments · Fixed by #3422
Assignees
Labels

Comments

@abuna1985
Copy link
Member

abuna1985 commented Aug 12, 2021

Overview

We need to refactor for buttons within the Home page from the recommendations in the CSS standardization spreadsheet (resource below) so that we have a consistent button appearance through the HfLA site.

Action Items

  • Make the 8 recommended edits for the buttons from the spreadsheet below (4 files will be updated)
    • Update line 4 of website/_includes/donate-button.html with HTML from the Reccomendation column
    • Update line 5 of website/_includes/footer.html with HTML from the Reccomendation column
    • Update line 2 of website/_includes/_includes/home-getting-started.html with HTML from the Reccomendation column
    • Update line 10 of website/_includes/forms/contact-us.html with HTML from the Reccomendation column
    • Update line 14 of website/_includes/forms/contact-us.html with HTML from the Reccomendation column
    • Update line 25 of website/_includes/forms/contact-us.html with HTML from the Reccomendation column
    • Update line 30 of website/_includes/forms/contact-us.html with HTML from the Reccomendation column
    • Update line 35 of website/_includes/forms/contact-us.html with HTML from the Reccomendation column
  • Confirm after the recommended edits that the Action of each button works as intended within the Home page
  • Update CSS to ensure the buttons remain the same as before
  • Create a Pull Request with the proposed changes to the button

Resources/Instructions

Google Sheets - CSS Standardization Buttons
#1921

@github-actions
Copy link

Hi @abuna1985.

Good job adding the required labels to this issue.

Just a friendly reminder to also move the issue into the "New Issue Approval" column under the Project Board. For more info on that, check Github's documentation here.
Thanks!

Additional Resources:
Wiki: How to add status labels to issues (WIP. Link will be updated when the wiki is done)
Wiki: How to create issues (WIP. Link will be updated when the wiki is done)

@sheltoG

This comment has been minimized.

@abuna1985 abuna1985 changed the title Complete refactor/standardization of all buttons within HfLA website Complete refactor/standardization of all buttons within Home Page Aug 22, 2021
@abuna1985 abuna1985 added P-Feature: Home page https://www.hackforla.org/ Complexity: Small Take this type of issues after the successful merge of your second good first issue and removed Feature: Design system Complexity: Medium labels Aug 22, 2021
@abuna1985

This comment has been minimized.

@ExperimentsInHonesty ExperimentsInHonesty added the Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages label Aug 25, 2021
@ExperimentsInHonesty ExperimentsInHonesty added this to the y. Technical debt milestone Sep 5, 2021
@abuna1985 abuna1985 added Feature: Refactor HTML Feature: Design system Complexity: Medium and removed Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages Complexity: Small Take this type of issues after the successful merge of your second good first issue labels Sep 7, 2021
@abuna1985 abuna1985 self-assigned this Sep 11, 2021
@abuna1985 abuna1985 pinned this issue Sep 12, 2021
@abuna1985 abuna1985 removed their assignment Sep 12, 2021
@ExperimentsInHonesty
Copy link
Member

@abuna1985 this issue is pinned to the issues homepage Can you explain why?

@abuna1985 abuna1985 unpinned this issue Sep 19, 2021
@abuna1985
Copy link
Member Author

@ExperimentsInHonesty My apologies. I thought pinning an issue was for individual views not for the entire team. The issue has been unpinned.

@github-actions
Copy link

Hi @Zak234, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@Zak234
Copy link
Contributor

Zak234 commented Jul 16, 2022

ETA: 1 day
Availability: Anytime

@Zak234
Copy link
Contributor

Zak234 commented Jul 17, 2022

Update:
Made changes and tested code. Changes 1, 2 and 3 do not work as intended while the rest seem to be working fine. Will try and update changes 1, 2 and 3 to work properly.

ETA: 1 day

@Zak234
Copy link
Contributor

Zak234 commented Jul 19, 2022

My mistake. Change 3 works fine but changes 4 and 5 don't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

5 participants