Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust footer position #2125

Closed
2 of 5 tasks
blakes24 opened this issue Aug 17, 2021 · 22 comments · Fixed by #2390
Closed
2 of 5 tasks

Adjust footer position #2125

blakes24 opened this issue Aug 17, 2021 · 22 comments · Fixed by #2390
Assignees
Labels
Bug Something isn't working Complexity: Medium Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages Fun Congrats! You finished two good first issues. Please only do one of these P-Feature: Footer role: front end Tasks for front end developers size: missing

Comments

@blakes24
Copy link
Member

blakes24 commented Aug 17, 2021

Overview

We need to move the footer to a fixed position at the bottom of all pages so we can have a consistent look for the page footer no matter the width of the page (all breakpoints).

  • Redirect page: issue is present for all screen sizes
Redirect Page screenshot Screen Shot 2021-08-17 at 3 14 21 PM
  • 404 page: observed for screen widths between 480px and 767px, above 1453px, and in ipad pro view from chrome dev tools (screen height also affects whether the footer is above the bottom of the page)
404 Page screenshot Screen Shot 2021-08-17 at 3 11 13 PM
  • Project page: screen widths above 768px it is possible to scroll past the footer when projects are filtered to a single row of results
Project Page screenshot (filtered to only show 2 projects) Screen Shot 2021-08-17 at 3 06 58 PM

Action Items

  • Adjust footer position so that it is always at the bottom of the page (fixed position at the bottom of each page)
  • Ensure that the correction doesn't break any other pages that are connected to your changes

Resources/Instructions

footer.html
_layouts/default.html

@blakes24 blakes24 added Bug Something isn't working role: front end Tasks for front end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue labels Aug 17, 2021
@github-actions github-actions bot added the Feature Missing This label means that the issue needs to be linked to a precise feature label. label Aug 17, 2021
@ExperimentsInHonesty ExperimentsInHonesty added P-Feature: Footer and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. labels Aug 18, 2021
@macho-catt

This comment has been minimized.

@blakes24

This comment has been minimized.

@ExperimentsInHonesty ExperimentsInHonesty added Fun Congrats! You finished two good first issues. Please only do one of these and removed Ready for Prioritization labels Aug 25, 2021
@abuna1985 abuna1985 added Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages Complexity: Medium and removed Complexity: Small Take this type of issues after the successful merge of your second good first issue labels Sep 7, 2021
@R-Tomas-Gonzalez R-Tomas-Gonzalez self-assigned this Sep 15, 2021
@github-actions

This comment has been minimized.

@github-actions github-actions bot added the To Update ! No update has been provided label Sep 17, 2021
@abuna1985 abuna1985 removed the To Update ! No update has been provided label Sep 19, 2021
@Abel-Zambrano Abel-Zambrano self-assigned this Oct 5, 2021
@github-actions
Copy link

github-actions bot commented Oct 8, 2021

@Abel-Zambrano

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, October 5, 2021 at 12:02 AM PST.

@github-actions github-actions bot added the To Update ! No update has been provided label Oct 8, 2021
@Abel-Zambrano
Copy link
Contributor

Progress: Fixed footer on 404 page.
Blockers: Generating the "redirecting" page.
Availability: 5hrs
ETA: 9/13/21

@Abel-Zambrano
Copy link
Contributor

@blakes24 Hello, do you have any steps or a specific link/url that I can use to generate the "redirect" page?

@Abel-Zambrano Abel-Zambrano removed the To Update ! No update has been provided label Oct 9, 2021
@macho-catt
Copy link
Member

@Abel-Zambrano, you can manipulate the line in the code:

<meta http-equiv="refresh" content="0;url={{ page.redirect_to }}" />

Change content from 0 to 5 for example, for five seconds. Change the time to as long as you want so you can look at the page.
Line in code

@macho-catt
Copy link
Member

macho-catt commented Oct 21, 2021

@Abel-Zambrano as @abuna1985 mentioned, the redirect link only works for redirections. For a list of possible redirections, you can refer to this directory in the code: https://github.com/hackforla/website/tree/gh-pages/redirections

Now every time you go to a permalink from that directory (like the donate permalink, which is pointing to /codeforamerica) it will first lead you to the redirect page, then the actual page of redirection. By increasing the seconds from 0 to 5, this redirect page will show for longer.

Thanks!

@github-actions github-actions bot added the Status: Updated No blockers and update is ready for review label Oct 22, 2021
@abuna1985
Copy link
Member

@Abel-Zambrano I found the following issues with both the projects page & wins page

Click here to see projects page gif

Noitice when there is 1 card, the footer goes under the card and the height stays as long as the dropdown filter menu

The footer is not at the bottom

Projects - Hack for LA

screenshot of footer display error (wins page)

screencapture-hackforla-org-projects-2021-10-22-21_22_24

Click here to see wins page gif

Noitice when there is 0card, the footer goes under the blank space and the height stays as long as the dropdown filter menu

The footer is not at the bottom

Wins - Hack for LA

screenshot of footer display error (wins page)

screencapture-hackforla-org-wins-2021-10-22-21_21_36

@github-actions github-actions bot removed the Status: Updated No blockers and update is ready for review label Oct 29, 2021
@github-actions
Copy link

@Abel-Zambrano

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, October 26, 2021 at 12:03 AM PST.

@github-actions github-actions bot added the To Update ! No update has been provided label Oct 29, 2021
@Abel-Zambrano
Copy link
Contributor

Progress: Complete
Blockers: Waiting for merge approval
Availability: n/a
ETA: n/a

@Abel-Zambrano Abel-Zambrano removed the To Update ! No update has been provided label Oct 30, 2021
@github-actions
Copy link

github-actions bot commented Nov 5, 2021

@Abel-Zambrano

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, November 2, 2021 at 12:03 AM PST.

@github-actions github-actions bot added the To Update ! No update has been provided label Nov 5, 2021
@github-actions github-actions bot added To Update ! No update has been provided and removed To Update ! No update has been provided labels Nov 12, 2021
@github-actions
Copy link

@Abel-Zambrano

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Monday, November 8, 2021 at 11:03 PM PST.

@Abel-Zambrano
Copy link
Contributor

Progress: Fixed footer on all pages except redirect page.
Blockers: n/a.
Availability: 2hrs
ETA: 11/19/2021

@Abel-Zambrano Abel-Zambrano removed the To Update ! No update has been provided label Nov 13, 2021
@github-actions
Copy link

@Abel-Zambrano

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Thursday, November 18, 2021 at 4:50 PM PST.

@github-actions github-actions bot added the To Update ! No update has been provided label Nov 22, 2021
@Abel-Zambrano
Copy link
Contributor

Progress: Complete
Blockers: Pending Review
Availability: n/a
ETA: n/a

@github-actions github-actions bot added Status: Updated No blockers and update is ready for review and removed To Update ! No update has been provided labels Nov 26, 2021
@github-actions github-actions bot removed the Status: Updated No blockers and update is ready for review label Dec 3, 2021
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

@Abel-Zambrano

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Monday, November 29, 2021 at 11:19 PM PST.

@github-actions github-actions bot added the To Update ! No update has been provided label Dec 3, 2021
@Abel-Zambrano
Copy link
Contributor

Progress: Complete
Blockers: Pending Review
Availability: n/a
ETA: n/a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Complexity: Medium Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages Fun Congrats! You finished two good first issues. Please only do one of these P-Feature: Footer role: front end Tasks for front end developers size: missing
Projects
Development

Successfully merging a pull request may close this issue.

7 participants